Apply initial review feedback

app/assets/javascripts/analytics/devops_report/components/devops_score.vue

@@ -71,7 +71,7 @@ export default {
     :svg-path="noDataImagePath"
   >
     <template #description>
-      <div>{{ __('It may be several days before you see feature usage data.') }}</div>
+      <p class="gl-mb-0">{{ __('It may be several days before you see feature usage data.') }}</p>
       <gl-link :href="devopsReportDocsPath">{{
         __('Our documentation includes an example DevOps Score report.')
       }}</gl-link>

spec/frontend/admin/analytics/devops_score/components/devops_score_spec.js

@@ -25,8 +25,8 @@ describe('DevopsScore', () => {
     );
   };
 
-  const findTable = () => wrapper.find(GlTable);
-  const findEmptyState = () => wrapper.find(GlEmptyState);
+  const findTable = () => wrapper.findComponent(GlTable);
+  const findEmptyState = () => wrapper.findComponent(GlEmptyState);
   const findCol = (testId) => findTable().find(`[data-testid="${testId}"]`);
   const findUsageCol = () => findCol('usageCol');
   const findDevopsScoreApp = () => wrapper.findByTestId('devops-score-app');
@@ -48,7 +48,7 @@ describe('DevopsScore', () => {
       });
 
       it('contains a link to the feature documentation', () => {
-        expect(wrapper.find(GlLink).exists()).toBe(true);
+        expect(wrapper.findComponent(GlLink).exists()).toBe(true);
       });
     });
 
@@ -78,7 +78,7 @@ describe('DevopsScore', () => {
       });
 
       it('displays the single stat section', () => {
-        const component = wrapper.find(GlSingleStat);
+        const component = wrapper.findComponent(GlSingleStat);
 
         expect(component.exists()).toBe(true);
         expect(component.props('value')).toBe(devopsScoreMetricsData.averageScore.value);

spec/helpers/dev_ops_report_helper_spec.rb

@@ -9,9 +9,6 @@ RSpec.describe DevOpsReportHelper do
 
   describe '#devops_score_metrics' do
     let(:devops_score_metrics) { helper.devops_score_metrics(subject) }
-    let(:devops_score_metrics_blank) { helper.devops_score_metrics({}) }
-
-    it { expect(devops_score_metrics_blank).to eq({}) }
 
     it { expect(devops_score_metrics[:averageScore]).to eq({ scoreLevel: { icon: "status-alert", label: "Moderate", variant: "warning" }, value: "55.9" } ) }
 
@@ -34,5 +31,11 @@ RSpec.describe DevOpsReportHelper do
 
       it { expect(devops_score_metrics[:averageScore]).to eq({ scoreLevel: { icon: "status_success_solid", label: "High", variant: "success" }, value: "82.0" } ) }
     end
+
+    describe 'with blank metrics' do
+      let(:devops_score_metrics) { helper.devops_score_metrics({}) }
+
+      it { expect(devops_score_metrics).to eq({}) }
+    end
   end
 end