Merge branch '12742-remove-quarantine-push-size-check-flag' into 'master'

Remove quarantine_push_size_check feature flag

See merge request gitlab-org/gitlab-ee!14904

ee/lib/ee/gitlab/git_access.rb

@@ -120,7 +120,7 @@ module EE
       def check_quarantine_size?
         git_env = ::Gitlab::Git::HookEnv.all(repository.gl_repository)
 
-        git_env['GIT_OBJECT_DIRECTORY_RELATIVE'].present? && ::Feature.enabled?(:quarantine_push_size_check, default_enabled: true)
+        git_env['GIT_OBJECT_DIRECTORY_RELATIVE'].present?
       end
 
       def check_repository_disk_size

ee/spec/lib/gitlab/git_access_spec.rb

@@ -262,57 +262,45 @@ describe Gitlab::GitAccess do
           .to receive(:all)
           .with(repository.gl_repository)
           .and_return({ 'GIT_OBJECT_DIRECTORY_RELATIVE' => 'objects' })
-      end
-
-      context 'when quarantine_push_size_check feature is enabled (default)' do
-        let(:object_directory_size) { 1.megabyte }
 
-        before do
-          # Stub the object directory size to "simulate" quarantine size
-          allow(repository)
-            .to receive(:object_directory_size)
-            .and_return(object_directory_size)
-        end
+        # Stub the object directory size to "simulate" quarantine size
+        allow(repository)
+          .to receive(:object_directory_size)
+          .and_return(object_directory_size)
+      end
 
-        context 'when repository size is over limit' do
-          let(:repository_size) { 2.megabytes }
-          let(:repository_size_limit) { 1.megabyte }
+      let(:object_directory_size) { 1.megabyte }
 
-          it_behaves_like 'a push to repository over the limit'
-        end
+      context 'when repository size is over limit' do
+        let(:repository_size) { 2.megabytes }
+        let(:repository_size_limit) { 1.megabyte }
 
-        context 'when repository size is below the limit' do
-          let(:repository_size) { 1.megabyte }
-          let(:repository_size_limit) { 2.megabytes }
+        it_behaves_like 'a push to repository over the limit'
+      end
 
-          it_behaves_like 'a push to repository below the limit'
+      context 'when repository size is below the limit' do
+        let(:repository_size) { 1.megabyte }
+        let(:repository_size_limit) { 2.megabytes }
 
-          context 'when object directory (quarantine) size exceeds the limit' do
-            let(:object_directory_size) { 2.megabytes }
+        it_behaves_like 'a push to repository below the limit'
 
-            it 'rejects the push' do
-              expect do
-                push_changes("#{Gitlab::Git::BLANK_SHA} #{sha_with_2_mb_file} refs/heads/my_branch_2")
-              end.to raise_error(described_class::UnauthorizedError, /Your push to this repository would cause it to exceed the size limit/)
-            end
-          end
+        context 'when object directory (quarantine) size exceeds the limit' do
+          let(:object_directory_size) { 2.megabytes }
 
-          context 'when object directory (quarantine) size does not exceed the limit' do
-            it 'accepts the push' do
-              expect do
-                push_changes("#{Gitlab::Git::BLANK_SHA} #{sha_with_smallest_changes} refs/heads/my_branch_3")
-              end.not_to raise_error
-            end
+          it 'rejects the push' do
+            expect do
+              push_changes("#{Gitlab::Git::BLANK_SHA} #{sha_with_2_mb_file} refs/heads/my_branch_2")
+            end.to raise_error(described_class::UnauthorizedError, /Your push to this repository would cause it to exceed the size limit/)
           end
         end
-      end
 
-      context 'when quarantine_push_size_check feature is disabled' do
-        before do
-          stub_feature_flags(quarantine_push_size_check: false)
+        context 'when object directory (quarantine) size does not exceed the limit' do
+          it 'accepts the push' do
+            expect do
+              push_changes("#{Gitlab::Git::BLANK_SHA} #{sha_with_smallest_changes} refs/heads/my_branch_3")
+            end.not_to raise_error
+          end
         end
-
-        it_behaves_like 'a push to repository using git-rev-list for checking against repository size limit'
       end
     end