Commit a7eac516 authored by Enrique Alcántara's avatar Enrique Alcántara

Merge branch...

Merge branch '249791-replace-bstooltip-with-gltooltip-in-app-assets-javascripts-build_artifacts-js' into 'master'

Replace tooltip api calls with tooltips facade in build_artifacts.js

Closes #249791

See merge request gitlab-org/gitlab!44153
parents dd456683 08ee9910
......@@ -3,6 +3,7 @@
import $ from 'jquery';
import { visitUrl } from './lib/utils/url_utility';
import { parseBoolean } from './lib/utils/common_utils';
import { hide, initTooltips, show } from '~/tooltips';
export default class BuildArtifacts {
constructor() {
......@@ -10,6 +11,7 @@ export default class BuildArtifacts {
this.setupEntryClick();
this.setupTooltips();
}
// eslint-disable-next-line class-methods-use-this
disablePropagation() {
$('.top-block').on('click', '.download', e => {
......@@ -19,15 +21,17 @@ export default class BuildArtifacts {
e.stopImmediatePropagation();
});
}
// eslint-disable-next-line class-methods-use-this
setupEntryClick() {
return $('.tree-holder').on('click', 'tr[data-link]', function() {
visitUrl(this.dataset.link, parseBoolean(this.dataset.externalLink));
});
}
// eslint-disable-next-line class-methods-use-this
setupTooltips() {
$('.js-artifact-tree-tooltip').tooltip({
initTooltips({
placement: 'bottom',
// Stop the tooltip from hiding when we stop hovering the element directly
// We handle all the showing/hiding below
......@@ -38,14 +42,14 @@ export default class BuildArtifacts {
// But be placed below and in the middle of the file name
$('.js-artifact-tree-row')
.on('mouseenter', e => {
$(e.currentTarget)
.find('.js-artifact-tree-tooltip')
.tooltip('show');
const $el = $(e.currentTarget).find('.js-artifact-tree-tooltip');
show($el);
})
.on('mouseleave', e => {
$(e.currentTarget)
.find('.js-artifact-tree-tooltip')
.tooltip('hide');
const $el = $(e.currentTarget).find('.js-artifact-tree-tooltip');
hide($el);
});
}
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment