Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a8cc4ede
Commit
a8cc4ede
authored
Feb 19, 2020
by
Imre Farkas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Clarify the scope of the setting in ApprovalState model spec
parent
5145de2d
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
ee/spec/models/approval_state_spec.rb
ee/spec/models/approval_state_spec.rb
+4
-4
No files found.
ee/spec/models/approval_state_spec.rb
View file @
a8cc4ede
...
...
@@ -57,7 +57,7 @@ describe ApprovalState do
create_rule
(
users:
committers
)
end
context
'when self approval is disabled'
do
context
'when self approval is disabled
on project level
'
do
let
(
:merge_requests_author_approval
)
{
false
}
it
'excludes authors'
do
...
...
@@ -87,7 +87,7 @@ describe ApprovalState do
end
end
context
'when self approval is enabled'
do
context
'when self approval is enabled
on project level
'
do
let
(
:merge_requests_author_approval
)
{
true
}
it
'includes author'
do
...
...
@@ -117,7 +117,7 @@ describe ApprovalState do
end
end
context
'when committers approval is enabled'
do
context
'when committers approval is enabled
on project level
'
do
let
(
:merge_requests_author_approval
)
{
true
}
let
(
:merge_requests_disable_committers_approval
)
{
false
}
...
...
@@ -148,7 +148,7 @@ describe ApprovalState do
end
end
context
'when committers approval is disabled'
do
context
'when committers approval is disabled
on project level
'
do
let
(
:merge_requests_author_approval
)
{
true
}
let
(
:merge_requests_disable_committers_approval
)
{
true
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment