Merge branch 'app-logger-10' into 'master'

Use applogger in some files in lib/gitlab

See merge request gitlab-org/gitlab!41058

changelogs/unreleased/app-logger-10.yml

+---
+title: Use applogger in some files in lib/gitlab
+merge_request: 41058
+author: Rajendra Kadam
+type: other

lib/gitlab/auth.rb

@@ -117,7 +117,6 @@ module Gitlab
 
       private
 
-      # rubocop:disable Gitlab/RailsLogger
       def rate_limit!(rate_limiter, success:, login:)
         return if skip_rate_limit?(login: login)
 
@@ -132,12 +131,11 @@ module Gitlab
           # This returns true when the failures are over the threshold and the IP
           # is banned.
           if rate_limiter.register_fail!
-            Rails.logger.info "IP #{rate_limiter.ip} failed to login " \
+            Gitlab::AppLogger.info "IP #{rate_limiter.ip} failed to login " \
               "as #{login} but has been temporarily banned from Git auth"
           end
         end
       end
-      # rubocop:enable Gitlab/RailsLogger
 
       def skip_rate_limit?(login:)
         CI_JOB_USER == login

lib/gitlab/database.rb

@@ -335,7 +335,7 @@ module Gitlab
       end
     rescue Prometheus::Client::LabelSetValidator::LabelSetError => err
       # Ensure that errors in recording these metrics don't affect the operation of the application
-      Rails.logger.error("Unable to observe database transaction duration: #{err}") # rubocop:disable Gitlab/RailsLogger
+      Gitlab::AppLogger.error("Unable to observe database transaction duration: #{err}")
     end
 
     # MonkeyPatch for ActiveRecord::Base for adding observability

lib/gitlab/encoding_helper.rb

@@ -59,7 +59,7 @@ module Gitlab
         begin
           CharlockHolmes::Converter.convert(message, detect[:encoding], 'UTF-8')
         rescue ArgumentError => e
-          Rails.logger.warn("Ignoring error converting #{detect[:encoding]} into UTF8: #{e.message}") # rubocop:disable Gitlab/RailsLogger
+          Gitlab::AppLogger.warn("Ignoring error converting #{detect[:encoding]} into UTF8: #{e.message}")
 
           ''
         end