Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
aa05be53
Commit
aa05be53
authored
6 years ago
by
Jose
Committed by
Chantal Rollison
6 years ago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove comma from weight system notes
parent
5d538054
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
8 additions
and
3 deletions
+8
-3
ee/app/services/ee/system_note_service.rb
ee/app/services/ee/system_note_service.rb
+1
-1
ee/changelogs/unreleased/jivl-remove-comma-from-weight-system-notes.yml
...unreleased/jivl-remove-comma-from-weight-system-notes.yml
+5
-0
ee/spec/services/ee/issuable/common_system_notes_service_spec.rb
.../services/ee/issuable/common_system_notes_service_spec.rb
+1
-1
ee/spec/services/system_note_service_spec.rb
ee/spec/services/system_note_service_spec.rb
+1
-1
No files found.
ee/app/services/ee/system_note_service.rb
View file @
aa05be53
...
...
@@ -21,7 +21,7 @@ module EE
# Returns the created Note object
def
change_weight_note
(
noteable
,
project
,
author
)
body
=
noteable
.
weight
?
"changed weight to **
#{
noteable
.
weight
}
**
,
"
:
'removed the weight'
body
=
noteable
.
weight
?
"changed weight to **
#{
noteable
.
weight
}
**"
:
'removed the weight'
create_note
(
NoteSummary
.
new
(
noteable
,
project
,
author
,
body
,
action:
'weight'
))
end
end
...
...
This diff is collapsed.
Click to expand it.
ee/changelogs/unreleased/jivl-remove-comma-from-weight-system-notes.yml
0 → 100644
View file @
aa05be53
---
title
:
Remove the comma from the weight system notes
merge_request
:
5854
author
:
type
:
changed
This diff is collapsed.
Click to expand it.
ee/spec/services/ee/issuable/common_system_notes_service_spec.rb
View file @
aa05be53
...
...
@@ -6,6 +6,6 @@ describe Issuable::CommonSystemNotesService do
let
(
:issuable
)
{
create
(
:issue
)
}
describe
'#execute'
do
it_behaves_like
'system note creation'
,
{
weight:
5
},
'changed weight to **5**
,
'
it_behaves_like
'system note creation'
,
{
weight:
5
},
'changed weight to **5**'
end
end
This diff is collapsed.
Click to expand it.
ee/spec/services/system_note_service_spec.rb
View file @
aa05be53
...
...
@@ -39,7 +39,7 @@ describe SystemNoteService do
end
it
'sets the note text'
do
expect
(
subject
.
note
).
to
eq
"changed weight to **4**
,
"
expect
(
subject
.
note
).
to
eq
"changed weight to **4**"
end
end
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment