Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
aa291fd2
Commit
aa291fd2
authored
May 20, 2020
by
Ravishankar
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove the dead code and the associated worker
Adding changelog entry
parent
64f740c4
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
5 additions
and
45 deletions
+5
-45
app/workers/all_queues.yml
app/workers/all_queues.yml
+0
-8
app/workers/new_release_worker.rb
app/workers/new_release_worker.rb
+0
-18
changelogs/unreleased/rmv-worker-code.yml
changelogs/unreleased/rmv-worker-code.yml
+5
-0
config/sidekiq_queues.yml
config/sidekiq_queues.yml
+0
-2
spec/workers/new_release_worker_spec.rb
spec/workers/new_release_worker_spec.rb
+0
-17
No files found.
app/workers/all_queues.yml
View file @
aa291fd2
...
...
@@ -779,14 +779,6 @@
:weight:
2
:idempotent:
:tags: []
-
:name: notifications:new_release
:feature_category: :release_orchestration
:has_external_dependencies:
:urgency: :low
:resource_boundary: :unknown
:weight:
2
:idempotent:
:tags: []
-
:name: object_pool:object_pool_create
:feature_category: :gitaly
:has_external_dependencies:
...
...
app/workers/new_release_worker.rb
deleted
100644 → 0
View file @
64f740c4
# frozen_string_literal: true
# TODO: Worker can be removed in 13.2:
# https://gitlab.com/gitlab-org/gitlab/-/issues/218231
class
NewReleaseWorker
# rubocop:disable Scalability/IdempotentWorker
include
ApplicationWorker
queue_namespace
:notifications
feature_category
:release_orchestration
weight
2
def
perform
(
release_id
)
release
=
Release
.
preloaded
.
find_by_id
(
release_id
)
return
unless
release
NotificationService
.
new
.
send_new_release_notifications
(
release
)
end
end
changelogs/unreleased/rmv-worker-code.yml
0 → 100644
View file @
aa291fd2
---
title
:
Remove the unused worker code and its queue
merge_request
:
32595
author
:
Ravishankar
type
:
deprecated
config/sidekiq_queues.yml
View file @
aa291fd2
...
...
@@ -166,8 +166,6 @@
-
2
-
-
new_note
-
2
-
-
notifications
-
2
-
-
object_pool
-
1
-
-
object_storage
...
...
spec/workers/new_release_worker_spec.rb
deleted
100644 → 0
View file @
64f740c4
# frozen_string_literal: true
# TODO: Worker can be removed in 13.2:
# https://gitlab.com/gitlab-org/gitlab/-/issues/218231
require
'spec_helper'
RSpec
.
describe
NewReleaseWorker
do
let
(
:release
)
{
create
(
:release
)
}
it
'sends a new release notification'
do
expect_next_instance_of
(
NotificationService
)
do
|
instance
|
expect
(
instance
).
to
receive
(
:send_new_release_notifications
).
with
(
release
)
end
described_class
.
new
.
perform
(
release
.
id
)
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment