Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
abc98146
Commit
abc98146
authored
Jun 16, 2021
by
Jaime Martinez
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove new_release_page feature flag
Changelog: removed
parent
50b9d851
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
2 additions
and
26 deletions
+2
-26
app/controllers/projects/releases_controller.rb
app/controllers/projects/releases_controller.rb
+1
-3
app/helpers/releases_helper.rb
app/helpers/releases_helper.rb
+1
-5
config/feature_flags/development/new_release_page.yml
config/feature_flags/development/new_release_page.yml
+0
-8
spec/helpers/releases_helper_spec.rb
spec/helpers/releases_helper_spec.rb
+0
-10
No files found.
app/controllers/projects/releases_controller.rb
View file @
abc98146
...
...
@@ -26,9 +26,7 @@ class Projects::ReleasesController < Projects::ApplicationController
end
def
new
unless
Feature
.
enabled?
(
:new_release_page
,
project
,
default_enabled:
true
)
redirect_to
(
new_project_tag_path
(
@project
))
end
redirect_to
(
new_project_tag_path
(
@project
))
end
def
downloads
...
...
app/helpers/releases_helper.rb
View file @
abc98146
...
...
@@ -20,11 +20,7 @@ module ReleasesHelper
documentation_path:
help_page
}.
tap
do
|
data
|
if
can?
(
current_user
,
:create_release
,
@project
)
data
[
:new_release_path
]
=
if
Feature
.
enabled?
(
:new_release_page
,
@project
,
default_enabled:
true
)
new_project_release_path
(
@project
)
else
new_project_tag_path
(
@project
)
end
data
[
:new_release_path
]
=
new_project_release_path
(
@project
)
end
end
end
...
...
config/feature_flags/development/new_release_page.yml
deleted
100644 → 0
View file @
50b9d851
---
name
:
new_release_page
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/35367
rollout_issue_url
:
milestone
:
'
13.2'
type
:
development
group
:
group::release
default_enabled
:
true
spec/helpers/releases_helper_spec.rb
View file @
abc98146
...
...
@@ -48,16 +48,6 @@ RSpec.describe ReleasesHelper do
it
'points new_release_path to the "New Release" page'
do
expect
(
helper
.
data_for_releases_page
[
:new_release_path
]).
to
eq
(
new_project_release_path
(
project
))
end
context
'when the "new_release_page" feature flag is disabled'
do
before
do
stub_feature_flags
(
new_release_page:
false
)
end
it
'points new_release_path to the "New Tag" page'
do
expect
(
helper
.
data_for_releases_page
[
:new_release_path
]).
to
eq
(
new_project_tag_path
(
project
))
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment