Merge branch 'remove-ci_pipelines_vulnerability_occurrence_pipelines_pipeline_id-fk' into 'master'

Swap FK vulnerability_occurrence_pipelines.pipeline_id to ci_pipelines for LFK

See merge request gitlab-org/gitlab!78601

db/post_migrate/20220119203119_remove_ci_pipelines_vulnerability_occurrence_pipelines_pipeline_id_fk.rb

+# frozen_string_literal: true
+
+class RemoveCiPipelinesVulnerabilityOccurrencePipelinesPipelineIdFk < Gitlab::Database::Migration[1.0]
+  disable_ddl_transaction!
+
+  def up
+    with_lock_retries do
+      execute('LOCK ci_pipelines, vulnerability_occurrence_pipelines IN ACCESS EXCLUSIVE MODE')
+
+      remove_foreign_key_if_exists(:vulnerability_occurrence_pipelines, :ci_pipelines, name: "fk_rails_6421e35d7d")
+    end
+  end
+
+  def down
+    add_concurrent_foreign_key(:vulnerability_occurrence_pipelines, :ci_pipelines, name: "fk_rails_6421e35d7d", column: :pipeline_id, target_column: :id, on_delete: :cascade)
+  end
+end

db/schema_migrations/20220119203119

+c0f29fd7f960ffd92a65a00e8dce123b91a604f4d89b7cf0bc419fa80495e2e5
\ No newline at end of file

db/structure.sql

@@ -30631,9 +30631,6 @@ ALTER TABLE ONLY evidences
 ALTER TABLE ONLY jira_imports
     ADD CONSTRAINT fk_rails_63cbe52ada FOREIGN KEY (project_id) REFERENCES projects(id) ON DELETE CASCADE;
 
-ALTER TABLE ONLY vulnerability_occurrence_pipelines
-    ADD CONSTRAINT fk_rails_6421e35d7d FOREIGN KEY (pipeline_id) REFERENCES ci_pipelines(id) ON DELETE CASCADE;
-
 ALTER TABLE ONLY group_deploy_tokens
     ADD CONSTRAINT fk_rails_6477b01f6b FOREIGN KEY (deploy_token_id) REFERENCES deploy_tokens(id) ON DELETE CASCADE;
 

ee/spec/models/vulnerabilities/finding_pipeline_spec.rb

@@ -15,4 +15,11 @@ RSpec.describe Vulnerabilities::FindingPipeline do
     it { is_expected.to validate_presence_of(:pipeline) }
     it { is_expected.to validate_uniqueness_of(:pipeline_id).scoped_to(:occurrence_id) }
   end
+
+  context 'loose foreign key on vulnerability_occurrence_pipelines.pipeline_id' do
+    it_behaves_like 'cleanup by a loose foreign key' do
+      let!(:parent) { create(:ci_pipeline) }
+      let!(:model) { create(:vulnerabilities_finding_pipeline, pipeline: parent) }
+    end
+  end
 end

spec/lib/gitlab/database/no_cross_db_foreign_keys_spec.rb

@@ -44,7 +44,6 @@ RSpec.describe 'cross-database foreign keys' do
       dast_site_profiles_pipelines.ci_pipeline_id
       external_pull_requests.project_id
       vulnerability_feedback.pipeline_id
-      vulnerability_occurrence_pipelines.pipeline_id
       vulnerability_statistics.latest_pipeline_id
     ).freeze
   end