Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ac7a2f1b
Commit
ac7a2f1b
authored
Jul 12, 2019
by
Brandon Labuschagne
Committed by
Kushal Pandya
Jul 12, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Prevent errors when CA has no data
parent
cb0edce2
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
2 deletions
+8
-2
app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js
...ets/javascripts/cycle_analytics/cycle_analytics_bundle.js
+8
-2
No files found.
app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js
View file @
ac7a2f1b
...
...
@@ -17,6 +17,7 @@ Vue.use(Translate);
export
default
()
=>
{
const
OVERVIEW_DIALOG_COOKIE
=
'
cycle_analytics_help_dismissed
'
;
const
cycleAnalyticsEl
=
document
.
querySelector
(
'
#cycle-analytics
'
);
// eslint-disable-next-line no-new
new
Vue
({
...
...
@@ -33,7 +34,6 @@ export default () => {
'
stage-production-component
'
:
stageComponent
,
},
data
()
{
const
cycleAnalyticsEl
=
document
.
querySelector
(
'
#cycle-analytics
'
);
const
cycleAnalyticsService
=
new
CycleAnalyticsService
({
requestPath
:
cycleAnalyticsEl
.
dataset
.
requestPath
,
});
...
...
@@ -56,7 +56,13 @@ export default () => {
},
},
created
()
{
this
.
fetchCycleAnalyticsData
();
// Conditional check placed here to prevent this method from being called on the
// new Cycle Analytics page (i.e. the new page will be initialized blank and only
// after a group is selected the cycle analyitcs data will be fetched). Once the
// old (current) page has been removed this entire created method as well as the
// variable itself can be completely removed.
// Follow up issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/64490
if
(
cycleAnalyticsEl
.
dataset
.
requestPath
)
this
.
fetchCycleAnalyticsData
();
},
methods
:
{
handleError
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment