Fix checkmark position on dropdowns

Remove nesting of .dropdown-item, so it is less specific than
.gl-new-dropdown.

This could potentially change specificity in case of existing overrides.
For any `.dropdown-item`s that have another class applied that class
could now take precedence over the dropdown-menu styles. However every
instance I can find is adding utility classes, which are already
intentionally more specific than nested `.dropdown-item` (mostly utils
using `!important`)

app/assets/stylesheets/framework/dropdowns.scss

@@ -317,13 +317,6 @@
     }
   }
 
-  // Temporary fix to ensure tick is aligned
-  // Follow up Issue to remove after the GlNewDropdownItem component is fixed
-  // > https://gitlab.com/gitlab-org/gitlab/-/issues/213948
-  li:not(.gl-new-dropdown-item) .dropdown-item {
-    @include dropdown-link;
-  }
-
   .divider {
     height: 1px;
     margin: #{$grid-size / 2} 0;
@@ -384,6 +377,10 @@
   }
 }
 
+.dropdown-item {
+  @include dropdown-link;
+}
+
 .droplab-dropdown {
   .dropdown-toggle > i {
     pointer-events: none;

changelogs/unreleased/psi-dropdown-item-check.yml

+---
+title: Fix checkmark position on dropdowns
+merge_request: 30685
+author:
+type: fixed