Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ad78fef7
Commit
ad78fef7
authored
Apr 28, 2021
by
Amy Qualls
Committed by
Jacques Erasmus
Apr 28, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Improve merge message UI text
parent
3b316758
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
18 additions
and
6 deletions
+18
-6
app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_merging.vue
...ge_request_widget/components/states/mr_widget_merging.vue
+4
-1
changelogs/unreleased/323061-aqualls-merging.yml
changelogs/unreleased/323061-aqualls-merging.yml
+5
-0
locale/gitlab.pot
locale/gitlab.pot
+3
-3
spec/features/merge_request/user_sees_merge_widget_spec.rb
spec/features/merge_request/user_sees_merge_widget_spec.rb
+1
-1
spec/frontend/vue_mr_widget/components/states/mr_widget_merging_spec.js
...vue_mr_widget/components/states/mr_widget_merging_spec.js
+5
-1
No files found.
app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_merging.vue
View file @
ad78fef7
...
@@ -19,7 +19,10 @@ export default {
...
@@ -19,7 +19,10 @@ export default {
<div
class=
"mr-widget-body mr-state-locked media"
>
<div
class=
"mr-widget-body mr-state-locked media"
>
<status-icon
status=
"loading"
/>
<status-icon
status=
"loading"
/>
<div
class=
"media-body"
>
<div
class=
"media-body"
>
<h4>
{{
s__
(
'
mrWidget|This merge request is in the process of being merged
'
)
}}
</h4>
<h4>
{{
s__
(
'
mrWidget|Merging! Drum roll, please…
'
)
}}
<gl-emoji
data-name=
"drum"
/>
</h4>
<section
class=
"mr-info-list"
>
<section
class=
"mr-info-list"
>
<p>
<p>
{{
s__
(
'
mrWidget|The changes will be merged into
'
)
}}
{{
s__
(
'
mrWidget|The changes will be merged into
'
)
}}
...
...
changelogs/unreleased/323061-aqualls-merging.yml
0 → 100644
View file @
ad78fef7
---
title
:
Improve merge message UI text
merge_request
:
59693
author
:
type
:
changed
locale/gitlab.pot
View file @
ad78fef7
...
@@ -38132,6 +38132,9 @@ msgstr ""
...
@@ -38132,6 +38132,9 @@ msgstr ""
msgid "mrWidget|Merged by"
msgid "mrWidget|Merged by"
msgstr ""
msgstr ""
msgid "mrWidget|Merging! Drum roll, please…"
msgstr ""
msgid "mrWidget|More information"
msgid "mrWidget|More information"
msgstr ""
msgstr ""
...
@@ -38225,9 +38228,6 @@ msgstr ""
...
@@ -38225,9 +38228,6 @@ msgstr ""
msgid "mrWidget|This merge request failed to be merged automatically"
msgid "mrWidget|This merge request failed to be merged automatically"
msgstr ""
msgstr ""
msgid "mrWidget|This merge request is in the process of being merged"
msgstr ""
msgid "mrWidget|This project is archived, write access has been disabled"
msgid "mrWidget|This project is archived, write access has been disabled"
msgstr ""
msgstr ""
...
...
spec/features/merge_request/user_sees_merge_widget_spec.rb
View file @
ad78fef7
...
@@ -445,7 +445,7 @@ RSpec.describe 'Merge request > User sees merge widget', :js do
...
@@ -445,7 +445,7 @@ RSpec.describe 'Merge request > User sees merge widget', :js do
wait_for_requests
wait_for_requests
expect
(
page
).
not_to
have_button
(
'Merge'
)
expect
(
page
).
not_to
have_button
(
'Merge'
)
expect
(
page
).
to
have_content
(
'
This merge request is in the process of being merged
'
)
expect
(
page
).
to
have_content
(
'
Merging! Drum roll, please…
'
)
end
end
end
end
...
...
spec/frontend/vue_mr_widget/components/states/mr_widget_merging_spec.js
View file @
ad78fef7
...
@@ -4,6 +4,7 @@ import MrWidgetMerging from '~/vue_merge_request_widget/components/states/mr_wid
...
@@ -4,6 +4,7 @@ import MrWidgetMerging from '~/vue_merge_request_widget/components/states/mr_wid
describe
(
'
MRWidgetMerging
'
,
()
=>
{
describe
(
'
MRWidgetMerging
'
,
()
=>
{
let
wrapper
;
let
wrapper
;
const
GlEmoji
=
{
template
:
'
<img />
'
};
beforeEach
(()
=>
{
beforeEach
(()
=>
{
wrapper
=
shallowMount
(
MrWidgetMerging
,
{
wrapper
=
shallowMount
(
MrWidgetMerging
,
{
propsData
:
{
propsData
:
{
...
@@ -12,6 +13,9 @@ describe('MRWidgetMerging', () => {
...
@@ -12,6 +13,9 @@ describe('MRWidgetMerging', () => {
targetBranch
:
'
branch
'
,
targetBranch
:
'
branch
'
,
},
},
},
},
stubs
:
{
GlEmoji
,
},
});
});
});
});
...
@@ -27,7 +31,7 @@ describe('MRWidgetMerging', () => {
...
@@ -27,7 +31,7 @@ describe('MRWidgetMerging', () => {
.
trim
()
.
trim
()
.
replace
(
/
\s\s
+/g
,
'
'
)
.
replace
(
/
\s\s
+/g
,
'
'
)
.
replace
(
/
[\r\n]
+/g
,
'
'
),
.
replace
(
/
[\r\n]
+/g
,
'
'
),
).
toContain
(
'
This merge request is in the process of being merged
'
);
).
toContain
(
'
Merging! Drum roll, please…
'
);
});
});
it
(
'
renders branch information
'
,
()
=>
{
it
(
'
renders branch information
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment