Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ae30457b
Commit
ae30457b
authored
Apr 09, 2021
by
Huzaifa Iftikhar
Committed by
Igor Drozdov
Apr 09, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix EmptyLineAfterFinalLetItBe offenses in spec/models/blob_viewer
parent
162e5fee
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
7 additions
and
2 deletions
+7
-2
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-2
changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-models-blob-viewer.yml
...836-fix-empty-line-after-let-it-be-models-blob-viewer.yml
+5
-0
spec/models/blob_viewer/gitlab_ci_yml_spec.rb
spec/models/blob_viewer/gitlab_ci_yml_spec.rb
+1
-0
spec/models/blob_viewer/metrics_dashboard_yml_spec.rb
spec/models/blob_viewer/metrics_dashboard_yml_spec.rb
+1
-0
No files found.
.rubocop_manual_todo.yml
View file @
ae30457b
...
...
@@ -1145,8 +1145,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
-
spec/models/abuse_report_spec.rb
-
spec/models/alert_management/alert_spec.rb
-
spec/models/audit_event_spec.rb
-
spec/models/blob_viewer/gitlab_ci_yml_spec.rb
-
spec/models/blob_viewer/metrics_dashboard_yml_spec.rb
-
spec/models/chat_name_spec.rb
-
spec/models/chat_team_spec.rb
-
spec/models/ci/artifact_blob_spec.rb
...
...
changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-models-blob-viewer.yml
0 → 100644
View file @
ae30457b
---
title
:
Fix EmptyLineAfterFinalLetItBe offenses in spec/models/blob_viewer
merge_request
:
58325
author
:
Huzaifa Iftikhar @huzaifaiftikhar
type
:
fixed
spec/models/blob_viewer/gitlab_ci_yml_spec.rb
View file @
ae30457b
...
...
@@ -8,6 +8,7 @@ RSpec.describe BlobViewer::GitlabCiYml do
let_it_be
(
:project
)
{
create
(
:project
,
:repository
)
}
let_it_be
(
:user
)
{
create
(
:user
)
}
let
(
:data
)
{
File
.
read
(
Rails
.
root
.
join
(
'spec/support/gitlab_stubs/gitlab_ci.yml'
))
}
let
(
:blob
)
{
fake_blob
(
path:
'.gitlab-ci.yml'
,
data:
data
)
}
let
(
:sha
)
{
sample_commit
.
id
}
...
...
spec/models/blob_viewer/metrics_dashboard_yml_spec.rb
View file @
ae30457b
...
...
@@ -7,6 +7,7 @@ RSpec.describe BlobViewer::MetricsDashboardYml do
include
RepoHelpers
let_it_be
(
:project
)
{
create
(
:project
,
:repository
)
}
let
(
:blob
)
{
fake_blob
(
path:
'.gitlab/dashboards/custom-dashboard.yml'
,
data:
data
)
}
let
(
:sha
)
{
sample_commit
.
id
}
let
(
:data
)
{
fixture_file
(
'lib/gitlab/metrics/dashboard/sample_dashboard.yml'
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment