Merge branch 'mc/backstage/nplusone-pipeline-show' into 'master'

Preload tags when loading commit statuses

Closes #28254

See merge request gitlab-org/gitlab!21000

app/models/ci/legacy_stage.rb

@@ -5,6 +5,7 @@ module Ci
   # We should migrate this object to actual database record in the future
   class LegacyStage
     include StaticModel
+    include Presentable
 
     attr_reader :pipeline, :name
 

app/presenters/ci/legacy_stage_presenter.rb

+# frozen_string_literal: true
+
+module Ci
+  class LegacyStagePresenter < Gitlab::View::Presenter::Delegated
+    presents :legacy_stage
+
+    def latest_ordered_statuses
+      preload_statuses(legacy_stage.statuses.latest_ordered)
+    end
+
+    def retried_ordered_statuses
+      preload_statuses(legacy_stage.statuses.retried_ordered)
+    end
+
+    private
+
+    def preload_statuses(statuses)
+      statuses.tap do |statuses|
+        # rubocop: disable CodeReuse/ActiveRecord
+        ActiveRecord::Associations::Preloader.new.preload(preloadable_statuses(statuses), :tags)
+        # rubocop: enable CodeReuse/ActiveRecord
+      end
+    end
+
+    def preloadable_statuses(statuses)
+      statuses.reject do |status|
+        status.instance_of?(::GenericCommitStatus) || status.instance_of?(::Ci::Bridge)
+      end
+    end
+  end
+end

app/views/projects/stage/_stage.html.haml

+- stage = stage.present(current_user: current_user)
+
 %tr
   %th{ colspan: 10 }
     %strong
@@ -6,8 +8,8 @@
         = ci_icon_for_status(stage.status)
        
       = stage.name.titleize
-= render stage.statuses.latest_ordered, stage: false, ref: false, pipeline_link: false, allow_retry: true
-= render stage.statuses.retried_ordered, stage: false, ref: false, pipeline_link: false, retried: true
+= render stage.latest_ordered_statuses, stage: false, ref: false, pipeline_link: false, allow_retry: true
+= render stage.retried_ordered_statuses, stage: false, ref: false, pipeline_link: false, retried: true
 %tr
   %td{ colspan: 10 }
      

spec/presenters/ci/legacy_stage_presenter_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Ci::LegacyStagePresenter do
+  let(:legacy_stage) { create(:ci_stage) }
+  let(:presenter) { described_class.new(legacy_stage) }
+
+  let!(:build) { create(:ci_build, :tags, pipeline: legacy_stage.pipeline, stage: legacy_stage.name) }
+  let!(:retried_build) { create(:ci_build, :tags, :retried, pipeline: legacy_stage.pipeline, stage: legacy_stage.name) }
+
+  before do
+    create(:generic_commit_status, pipeline: legacy_stage.pipeline, stage: legacy_stage.name)
+  end
+
+  describe '#latest_ordered_statuses' do
+    subject(:latest_ordered_statuses) { presenter.latest_ordered_statuses }
+
+    it 'preloads build tags' do
+      expect(latest_ordered_statuses.second.association(:tags)).to be_loaded
+    end
+  end
+
+  describe '#retried_ordered_statuses' do
+    subject(:retried_ordered_statuses) { presenter.retried_ordered_statuses }
+
+    it 'preloads build tags' do
+      expect(retried_ordered_statuses.first.association(:tags)).to be_loaded
+    end
+  end
+end