Merge branch 'remove-feature_flag_contextual_issue' into 'master'

Clean up feature_flag_contextual_issue feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!53816

changelogs/unreleased/remove-feature_flag_contextual_issue.yml

+---
+title: Support Markdown for Feature Flags
+merge_request: 53816
+author:
+type: added

config/feature_flags/development/feature_flag_contextual_issue.yml

----
-name: feature_flag_contextual_issue
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/53021
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/320741
-milestone: '13.9'
-type: development
-group: group::release
-default_enabled: false

doc/user/markdown.md

@@ -444,6 +444,7 @@ GFM recognizes the following:
 | snippet                         | `$123`                     | `namespace/project$123`                 | `project$123`                  |
 | epic **(ULTIMATE)**             | `&123`                     | `group1/subgroup&123`                   |                                |
 | vulnerability **(ULTIMATE)** (1)| `[vulnerability:123]`      | `[vulnerability:namespace/project/123]` | `[vulnerability:project/123]`  |
+| feature flag                    | `[feature_flag:123]`       | `[feature_flag:namespace/project/123]`  | `[feature_flag:project/123]`   |
 | label by ID                     | `~123`                     | `namespace/project~123`                 | `project~123`                  |
 | one-word label by name          | `~bug`                     | `namespace/project~bug`                 | `project~bug`                  |
 | multi-word label by name        | `~"feature request"`       | `namespace/project~"feature request"`   | `project~"feature request"`    |

lib/banzai/filter/feature_flag_reference_filter.rb

@@ -14,8 +14,6 @@ module Banzai
       end
 
       def parent_records(parent, ids)
-        return self.class.object_class.none unless Feature.enabled?(:feature_flag_contextual_issue, parent)
-
         parent.operations_feature_flags.where(iid: ids.to_a)
       end
 

spec/lib/banzai/filter/feature_flag_reference_filter_spec.rb

@@ -82,18 +82,6 @@ RSpec.describe Banzai::Filter::FeatureFlagReferenceFilter do
       expect(link).not_to match %r(https?://)
       expect(link).to eq urls.edit_project_feature_flag_url(project, feature_flag.iid, only_path: true)
     end
-
-    context 'when feature_flag_contextual_issue feture flag is disabled' do
-      before do
-        stub_feature_flags(feature_flag_contextual_issue: false)
-      end
-
-      it 'does not link the reference' do
-        doc = reference_filter("See #{reference}")
-
-        expect(doc.css('a').first).to be_nil
-      end
-    end
   end
 
   context 'with cross-project / cross-namespace complete reference' do