Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b3314704
Commit
b3314704
authored
Oct 23, 2015
by
Douwe Maan
Committed by
Valery Sizov
Oct 23, 2015
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update ExternalIssueReferenceFilter.
parent
0f30be02
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
5 deletions
+15
-5
lib/gitlab/markdown/external_issue_reference_filter.rb
lib/gitlab/markdown/external_issue_reference_filter.rb
+14
-4
spec/lib/gitlab/markdown/external_issue_reference_filter_spec.rb
...b/gitlab/markdown/external_issue_reference_filter_spec.rb
+1
-1
No files found.
lib/gitlab/markdown/external_issue_reference_filter.rb
View file @
b3314704
...
...
@@ -23,6 +23,18 @@ module Gitlab
end
end
def
self
.
referenced_by
(
node
)
project
=
Project
.
find
(
node
.
attr
(
"data-project"
))
rescue
nil
return
unless
project
id
=
node
.
attr
(
"data-external-issue"
)
external_issue
=
ExternalIssue
.
new
(
id
,
project
)
return
unless
external_issue
{
external_issue:
external_issue
}
end
def
call
# Early return if the project isn't using an external tracker
return
doc
if
project
.
nil?
||
project
.
default_issues_tracker?
...
...
@@ -43,15 +55,13 @@ module Gitlab
project
=
context
[
:project
]
self
.
class
.
references_in
(
text
)
do
|
match
,
id
|
issue
=
ExternalIssue
.
new
(
id
,
project
)
push_result
(
:external_issue
,
issue
)
ExternalIssue
.
new
(
id
,
project
)
url
=
url_for_issue
(
id
,
project
,
only_path:
context
[
:only_path
])
title
=
escape_once
(
"Issue in
#{
project
.
external_issue_tracker
.
title
}
"
)
klass
=
reference_class
(
:issue
)
data
=
data_attribute
(
project:
project
.
id
)
data
=
data_attribute
(
project:
project
.
id
,
external_issue:
id
)
%(<a href="#{url}" #{data}
title="#{title}"
...
...
spec/lib/gitlab/markdown/external_issue_reference_filter_spec.rb
View file @
b3314704
...
...
@@ -78,7 +78,7 @@ module Gitlab::Markdown
it
'adds to the results hash'
do
ext
=
JiraIssue
.
new
(
reference
,
project
)
result
=
pipeline_result
(
"Issue
#{
reference
}
"
)
result
=
reference_
pipeline_result
(
"Issue
#{
reference
}
"
)
expect
(
result
[
:references
][
:external_issue
]).
not_to
be_empty
expect
(
result
[
:references
][
:external_issue
]).
to
eq
[
ext
]
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment