Merge branch 'jl-update-geo-rake-specs' into 'master'

Update geo rake task specs

See merge request gitlab-org/gitlab-ee!15098

ee/spec/tasks/geo_rake_spec.rb

@@ -8,7 +8,236 @@ describe 'geo rake tasks', :geo do
     stub_licensed_features(geo: true)
   end
 
-  describe 'set_primary_node task' do
+  it 'Gitlab:Geo::DatabaseTasks responds to all methods used in Geo rake tasks' do
+    %i[
+      drop_current
+      create_current
+      migrate
+      rollback
+      version
+      load_schema_current
+      load_seed
+      dump_schema_after_migration?
+      pending_migrations
+    ].each do |method|
+      expect(Gitlab::Geo::DatabaseTasks).to respond_to(method)
+    end
+  end
+
+  it 'Gitlab::Geo::GeoTasks responds to all methods used in Geo rake tasks' do
+    %i[
+      foreign_server_configured?
+      refresh_foreign_tables!
+      set_primary_geo_node
+      update_primary_geo_node_url
+    ].each do |method|
+      expect(Gitlab::Geo::GeoTasks).to respond_to(method)
+    end
+  end
+
+  it 'Gitlab::Geo::DatabaseTasks::Migrate responds to all methods used in Geo rake tasks' do
+    %i[up down status].each do |method|
+      expect(Gitlab::Geo::DatabaseTasks::Migrate).to respond_to(method)
+    end
+  end
+
+  it 'Gitlab::Geo::DatabaseTasks::Test responds to all methods used in Geo rake tasks' do
+    %i[load purge].each do |method|
+      expect(Gitlab::Geo::DatabaseTasks::Test).to respond_to(method)
+    end
+  end
+
+  it 'Gitlab::Geo::DatabaseTasks::Schema responds to .dump method used in Geo rake tasks' do
+    expect(Gitlab::Geo::DatabaseTasks::Schema).to respond_to(:dump)
+  end
+
+  describe 'geo:db:drop' do
+    it 'drops the current database' do
+      expect(Gitlab::Geo::DatabaseTasks).to receive(:drop_current)
+
+      run_rake_task('geo:db:drop')
+    end
+  end
+
+  describe 'geo:db:create' do
+    it 'creates a Geo tracking database' do
+      expect(Gitlab::Geo::DatabaseTasks).to receive(:create_current)
+
+      run_rake_task('geo:db:create')
+    end
+  end
+
+  describe 'geo:db:migrate' do
+    it 'migrates a Geo tracking database' do
+      expect(Gitlab::Geo::DatabaseTasks).to receive(:migrate)
+      expect(Rake::Task['geo:db:_dump']).to receive(:invoke)
+
+      run_rake_task('geo:db:migrate')
+    end
+  end
+
+  describe 'geo:db:rollback' do
+    it 'rolls back a Geo tracking database' do
+      expect(Gitlab::Geo::DatabaseTasks).to receive(:rollback)
+      expect(Rake::Task['geo:db:_dump']).to receive(:invoke)
+
+      run_rake_task('geo:db:rollback')
+    end
+  end
+
+  describe 'geo:db:version' do
+    it 'retrieves current schema version number' do
+      expect(Gitlab::Geo::DatabaseTasks).to receive(:version)
+
+      run_rake_task('geo:db:version')
+    end
+  end
+
+  describe 'geo:db:reset' do
+    it 'drops, recreates database, and loads seeds' do
+      expect(Rake::Task['geo:db:drop']).to receive(:invoke)
+      expect(Rake::Task['geo:db:create']).to receive(:invoke)
+      expect(Rake::Task['geo:db:setup']).to receive(:invoke)
+
+      run_rake_task('geo:db:reset')
+    end
+  end
+
+  describe 'geo:db:seed' do
+    it 'loads seed data' do
+      allow(Rake::Task['geo:db:abort_if_pending_migrations']).to receive(:invoke).and_return(false)
+      expect(Gitlab::Geo::DatabaseTasks).to receive(:load_seed)
+
+      run_rake_task('geo:db:seed')
+    end
+  end
+
+  describe 'geo:db:refresh_foreign_tables' do
+    it 'refreshes foreign tables definition on secondary node' do
+      allow(Gitlab::Geo::GeoTasks).to receive(:foreign_server_configured?).and_return(true)
+      expect(Gitlab::Geo::GeoTasks).to receive(:refresh_foreign_tables!)
+
+      run_rake_task('geo:db:refresh_foreign_tables')
+    end
+  end
+
+  describe 'geo:db:_dump' do
+    it 'dumps the schema' do
+      allow(Gitlab::Geo::DatabaseTasks).to receive(:dump_schema_after_migration?).and_return(true)
+      expect(Rake::Task['geo:db:schema:dump']).to receive(:invoke)
+
+      run_rake_task('geo:db:_dump')
+    end
+  end
+
+  describe 'geo:db:abort_if_pending_migrations' do
+    it 'raises an error if there are pending migrations' do
+      pending_migration = double('pending migration', version: 12, name: 'Test')
+      allow(Gitlab::Geo::DatabaseTasks).to receive(:pending_migrations).and_return([pending_migration])
+
+      expect { run_rake_task('geo:db:abort_if_pending_migrations') }.to raise_error(%{Run `rake geo:db:migrate` to update your database then try again.})
+    end
+  end
+
+  describe 'geo:db:schema_load' do
+    it 'loads schema file into database' do
+      allow(ENV).to receive(:[]).with('SCHEMA')
+      expect(Gitlab::Geo::DatabaseTasks).to receive(:load_schema_current).with(:ruby, ENV['SCHEMA'])
+
+      run_rake_task('geo:db:schema:load')
+    end
+  end
+
+  describe 'geo:db:schema_dump' do
+    it 'creates schema.rb file' do
+      expect(Gitlab::Geo::DatabaseTasks::Schema).to receive(:dump)
+
+      run_rake_task('geo:db:schema:dump')
+    end
+  end
+
+  describe 'geo:db:migrate:up' do
+    it 'runs up method for given migration' do
+      expect(Gitlab::Geo::DatabaseTasks::Migrate).to receive(:up)
+      expect(Rake::Task['geo:db:_dump']).to receive(:invoke)
+
+      run_rake_task('geo:db:migrate:up')
+    end
+  end
+
+  describe 'geo:db:migrate:down' do
+    it 'runs down method for given migration' do
+      expect(Gitlab::Geo::DatabaseTasks::Migrate).to receive(:down)
+      expect(Rake::Task['geo:db:_dump']).to receive(:invoke)
+
+      run_rake_task('geo:db:migrate:down')
+    end
+  end
+
+  describe 'geo:db:migrate:redo' do
+    context 'without env var set' do
+      it 'does not run migrations' do
+        expect(Rake::Task['geo:db:migrate:down']).not_to receive(:invoke)
+        expect(Rake::Task['geo:db:rollback']).to receive(:invoke)
+
+        run_rake_task('geo:db:migrate:redo')
+      end
+    end
+
+    context 'with env var set' do
+      it 'does run migrations' do
+        allow(ENV).to receive(:[]).with('VERSION').and_return(1)
+        expect(Rake::Task['geo:db:migrate:down']).to receive(:invoke)
+        expect(Rake::Task['geo:db:rollback']).not_to receive(:invoke)
+
+        run_rake_task('geo:db:migrate:redo')
+      end
+    end
+  end
+
+  describe 'geo:db:migrate:status' do
+    it 'displays migration status' do
+      expect(Gitlab::Geo::DatabaseTasks::Migrate).to receive(:status)
+
+      run_rake_task('geo:db:migrate:status')
+    end
+  end
+
+  describe 'geo:db:test:prepare' do
+    it 'check for pending migrations and load schema in test environment' do
+      expect(Rake::Task['geo:db:test:load']).to receive(:invoke)
+
+      run_rake_task('geo:db:test:prepare')
+    end
+  end
+
+  describe 'geo:db:test:load' do
+    it 'recreates database in test environment' do
+      expect(Gitlab::Geo::DatabaseTasks::Test).to receive(:load)
+      expect(Gitlab::Geo::DatabaseTasks::Test).to receive(:purge)
+
+      run_rake_task('geo:db:test:load')
+    end
+  end
+
+  describe 'geo:db:test:purge' do
+    it 'empties database in test environment' do
+      expect(Gitlab::Geo::DatabaseTasks::Test).to receive(:purge)
+
+      run_rake_task('geo:db:test:purge')
+    end
+  end
+
+  describe 'geo:db:test:refresh_foreign_tables' do
+    it 'refreshes foreign tables definitions in test environment' do
+      allow(ActiveRecord::Tasks::DatabaseTasks).to receive(:env)
+      expect(Rake::Task['geo:db:refresh_foreign_tables']).to receive(:invoke)
+
+      run_rake_task('geo:db:test:refresh_foreign_tables')
+    end
+  end
+
+  describe 'geo:set_primary_node' do
     before do
       stub_config_setting(url: 'https://example.com:1234/relative_part')
       stub_geo_setting(node_name: 'Region 1 node')
@@ -30,7 +259,7 @@ describe 'geo rake tasks', :geo do
     end
   end
 
-  describe 'set_secondary_as_primary task' do
+  describe 'geo:set_secondary_as_primary' do
     let!(:current_node) { create(:geo_node) }
     let!(:primary_node) { create(:geo_node, :primary) }
 
@@ -46,7 +275,7 @@ describe 'geo rake tasks', :geo do
     end
   end
 
-  describe 'update_primary_node_url task' do
+  describe 'geo:update_primary_node_url' do
     let(:primary_node) { create(:geo_node, :primary, url: 'https://secondary.geo.example.com') }
 
     before do
@@ -61,7 +290,7 @@ describe 'geo rake tasks', :geo do
     end
   end
 
-  describe 'status task', :geo_fdw do
+  describe 'geo:status', :geo_fdw do
     context 'without a valid license' do
       before do
         stub_licensed_features(geo: false)