Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b5ea36f0
Commit
b5ea36f0
authored
Sep 28, 2020
by
Kerri Miller
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove codeowners_match_ancestor_groups feature flag
parent
ec7dd8c4
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
21 deletions
+10
-21
ee/config/feature_flags/development/codeowners_match_ancestor_groups.yml
...re_flags/development/codeowners_match_ancestor_groups.yml
+0
-7
ee/lib/gitlab/code_owners/groups_loader.rb
ee/lib/gitlab/code_owners/groups_loader.rb
+10
-14
No files found.
ee/config/feature_flags/development/codeowners_match_ancestor_groups.yml
deleted
100644 → 0
View file @
ec7dd8c4
---
name
:
codeowners_match_ancestor_groups
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/31887
rollout_issue_url
:
group
:
group::source code
type
:
development
default_enabled
:
true
ee/lib/gitlab/code_owners/groups_loader.rb
View file @
b5ea36f0
...
...
@@ -24,22 +24,18 @@ module Gitlab
groups
=
project
.
invited_groups
.
where_full_path_in
(
extractor
.
names
)
if
Feature
.
enabled?
(
:codeowners_match_ancestor_groups
,
default_enabled:
true
)
group_list
=
groups
.
with_route
.
with_users
.
to_a
if
project
.
group
# If the project.group's ancestor group(s) are listed as owners, add
# them to group_list
#
if
applicable_ancestors
(
extractor
.
names
).
any?
group_list
.
concat
(
applicable_ancestors
(
extractor
.
names
))
end
group_list
=
groups
.
with_route
.
with_users
.
to_a
if
project
.
group
# If the project.group's ancestor group(s) are listed as owners, add
# them to group_list
#
if
applicable_ancestors
(
extractor
.
names
).
any?
group_list
.
concat
(
applicable_ancestors
(
extractor
.
names
))
end
group_list
.
uniq
else
groups
.
with_route
.
with_users
end
group_list
.
uniq
end
def
applicable_ancestors
(
extractor_names
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment