Merge branch 'fix/attr-encrypted-ee-issue' into 'master'

fix attr_encrypted in EE

Same MR as https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4963/ for CE - but EE has some extra attributes missing.

Fixes #19073

See merge request !502

CHANGELOG-EE

@@ -2,6 +2,9 @@ Please view this file on the master branch, on stable branches it's out of date.
 
 v 8.10.0 (unreleased)
 
+v 8.9.3 (unreleased)
+  - Fix encrypted data backwards compatibility after upgrading attr_encrypted gem
+
 v 8.9.1
   - Improve Geo documentation. !431
   - Fix remote mirror stuck on started issue. !491

app/models/ci/variable.rb

@@ -13,6 +13,7 @@ module Ci
 
     attr_encrypted :value, 
        mode: :per_attribute_iv_and_salt,
+       insecure_mode: true,
        key: Gitlab::Application.secrets.db_key_base,
        algorithm: 'aes-256-cbc'
   end

app/models/pages_domain.rb

@@ -12,6 +12,7 @@ class PagesDomain < ActiveRecord::Base
 
   attr_encrypted :key,
     mode: :per_attribute_iv_and_salt,
+    insecure_mode: true,
     key: Gitlab::Application.secrets.db_key_base,
     algorithm: 'aes-256-cbc'
 

app/models/project_import_data.rb

@@ -7,6 +7,7 @@ class ProjectImportData < ActiveRecord::Base
                  marshal: true,
                  encode: true,
                  mode: :per_attribute_iv_and_salt,
+                 insecure_mode: true,
                  algorithm: 'aes-256-cbc'
 
   serialize :data, JSON

app/models/remote_mirror.rb

@@ -25,6 +25,7 @@ class RemoteMirror < ActiveRecord::Base
                  marshal: true,
                  encode: true,
                  mode: :per_attribute_iv_and_salt,
+                 insecure_mode: true,
                  algorithm: 'aes-256-cbc'
 
   belongs_to :project

app/models/user.rb

@@ -25,6 +25,7 @@ class User < ActiveRecord::Base
   attr_encrypted :otp_secret,
     key:       Gitlab::Application.config.secret_key_base,
     mode:      :per_attribute_iv_and_salt,
+    insecure_mode: true,
     algorithm: 'aes-256-cbc'
 
   devise :two_factor_authenticatable,