Move regex in constant

lib/gitlab/redis/hll.rb

@@ -3,6 +3,7 @@
 module Gitlab
   module Redis
     class HLL
+      KEY_REGEX = %r{\A(\w|-|:)*\{\w*\}(\w|-|:)*\z}.freeze
       KeyFormatError = Class.new(StandardError)
 
       def self.count(params)
@@ -25,8 +26,10 @@ module Gitlab
       #   project:{1}:set_a
       #   project:{1}:set_b
       #   project:{2}:set_c
+      #   2020-216-{project_action}
+      #   i_{analytics}_dev_ops_score-2020-32
       def add(key:, value:, expiry:)
-        unless %r{\A(\w|-|:)*\{\w*\}(\w|-|:)*\z}.match?(key)
+        unless KEY_REGEX.match?(key)
           raise KeyFormatError.new("Invalid key format. #{key} key should have changeable parts in curly braces. See https://docs.gitlab.com/ee/development/redis.html#multi-key-commands")
         end
 

spec/lib/gitlab/redis/hll_spec.rb

@@ -14,6 +14,8 @@ RSpec.describe Gitlab::Redis::HLL, :clean_gitlab_redis_shared_state do
       expect { described_class.add(key: 'test-{metric}', value: 1, expiry: 1.day) }.not_to raise_error
       expect { described_class.add(key: 'test-{metric}-1', value: 1, expiry: 1.day) }.not_to raise_error
       expect { described_class.add(key: 'test:{metric}-1', value: 1, expiry: 1.day) }.not_to raise_error
+      expect { described_class.add(key: '2020-216-{project_action}', value: 1, expiry: 1.day) }.not_to raise_error
+      expect { described_class.add(key: 'i_{analytics}_dev_ops_score-2020-32', value: 1, expiry: 1.day) }.not_to raise_error
     end
   end
 end