Merge branch 'es_database_indexer_skip_empty_projects' into 'master'

[Elastic][Fix] Database indexer skips invalid repos

https://gitlab.com/gitlab-org/gitlab-ee/issues/378

See merge request !353

CHANGELOG-EE

@@ -2,6 +2,7 @@ Please view this file on the master branch, on stable branches it's out of date.
 
 v 8.8.0 (unreleased)
   - [Elastic] Database indexer prints its status
+  - [Elastic][Fix] Database indexer skips projects with invalid HEAD reference
 
 v 8.7.2
   - Fix MR notifications for slack and hipchat when approvals are fullfiled. !325

lib/tasks/gitlab/elastic.rake

@@ -24,28 +24,30 @@ namespace :gitlab do
       indexer = Elastic::Indexer.new
 
       projects.find_each do |project|
-        if project.repository.exists? && !project.repository.empty?
+        repository = project.repository
+
+        if repository.exists? && !repository.empty?
           puts "Indexing #{project.name_with_namespace} (ID=#{project.id})..."
 
           index_status = IndexStatus.find_or_create_by(project: project)
 
           begin
-            head_sha = project.repository.commit.sha
+            head_commit = repository.commit
 
-            if index_status.last_commit == head_sha
+            if !head_commit || index_status.last_commit == head_commit.sha
               puts "Skipped".yellow
               next
             end
 
             indexer.run(
               project.id,
-              project.repository.path_to_repo,
-              project.index_status.last_commit
+              repository.path_to_repo,
+              index_status.last_commit
             )
 
             # During indexing the new commits can be pushed,
             # the last_commit parameter only indicates that at least this commit is in index
-            index_status.update(last_commit: head_sha, indexed_at: DateTime.now)
+            index_status.update(last_commit: head_commit.sha, indexed_at: DateTime.now)
             puts "Done!".green
           rescue StandardError => e
             puts "#{e.message}, trace - #{e.backtrace}"