Merge branch '325689-remove-delete-async-ffs' into 'master'

Remove issuable destroy service related FFs [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!61764

app/services/issuable/destroy_service.rb

@@ -26,25 +26,13 @@ module Issuable
     end
 
     def delete_todos(actor, issuable)
-      if Feature.enabled?(:destroy_issuable_todos_async, actor, default_enabled: :yaml)
-        TodosDestroyer::DestroyedIssuableWorker
-          .perform_async(issuable.id, issuable.class.name)
-      else
-        TodosDestroyer::DestroyedIssuableWorker
-          .new
-          .perform(issuable.id, issuable.class.name)
-      end
+      TodosDestroyer::DestroyedIssuableWorker
+        .perform_async(issuable.id, issuable.class.name)
     end
 
     def delete_label_links(actor, issuable)
-      if Feature.enabled?(:destroy_issuable_label_links_async, actor, default_enabled: :yaml)
-        Issuable::LabelLinksDestroyWorker
-          .perform_async(issuable.id, issuable.class.name)
-      else
-        Issuable::LabelLinksDestroyWorker
-          .new
-          .perform(issuable.id, issuable.class.name)
-      end
+      Issuable::LabelLinksDestroyWorker
+        .perform_async(issuable.id, issuable.class.name)
     end
   end
 end

changelogs/unreleased/325689-remove-delete-async-ffs.yml

+---
+title: Remove issuable destroy service related FFs
+merge_request: 61764
+author:
+type: other

config/feature_flags/development/destroy_issuable_label_links_async.yml

----
-name: destroy_issuable_label_links_async
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/60487
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/325689
-milestone: '13.12'
-type: development
-group: group::code review
-default_enabled: false

config/feature_flags/development/destroy_issuable_todos_async.yml

----
-name: destroy_issuable_todos_async
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/57830
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/325689
-milestone: '13.11'
-type: development
-group: group::code review
-default_enabled: false

spec/support/shared_examples/services/issuable/destroy_service_shared_examples.rb

 # frozen_string_literal: true
 
 shared_examples_for 'service deleting todos' do
-  before do
-    stub_feature_flags(destroy_issuable_todos_async: group)
-  end
-
   it 'destroys associated todos asynchronously' do
     expect(TodosDestroyer::DestroyedIssuableWorker)
       .to receive(:perform_async)
@@ -12,29 +8,9 @@ shared_examples_for 'service deleting todos' do
 
     subject.execute(issuable)
   end
-
-  context 'when destroy_issuable_todos_async feature is disabled for group' do
-    before do
-      stub_feature_flags(destroy_issuable_todos_async: false)
-    end
-
-    it 'destroy associated todos synchronously' do
-      expect_next_instance_of(TodosDestroyer::DestroyedIssuableWorker) do |worker|
-        expect(worker)
-          .to receive(:perform)
-          .with(issuable.id, issuable.class.name)
-      end
-
-      subject.execute(issuable)
-    end
-  end
 end
 
 shared_examples_for 'service deleting label links' do
-  before do
-    stub_feature_flags(destroy_issuable_label_links_async: group)
-  end
-
   it 'destroys associated label links asynchronously' do
     expect(Issuable::LabelLinksDestroyWorker)
       .to receive(:perform_async)
@@ -42,20 +18,4 @@ shared_examples_for 'service deleting label links' do
 
     subject.execute(issuable)
   end
-
-  context 'when destroy_issuable_label_links_async feature is disabled for group' do
-    before do
-      stub_feature_flags(destroy_issuable_label_links_async: false)
-    end
-
-    it 'destroy associated label links synchronously' do
-      expect_next_instance_of(Issuable::LabelLinksDestroyWorker) do |worker|
-        expect(worker)
-          .to receive(:perform)
-          .with(issuable.id, issuable.class.name)
-      end
-
-      subject.execute(issuable)
-    end
-  end
 end