Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b92c6d36
Commit
b92c6d36
authored
Sep 15, 2021
by
Changzheng Liu
Committed by
Thong Kuah
Sep 15, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Clarified some backend code comments
parent
751d82f7
Changes
10
Hide whitespace changes
Inline
Side-by-side
Showing
10 changed files
with
6 additions
and
14 deletions
+6
-14
app/presenters/projects/import_export/project_export_presenter.rb
...enters/projects/import_export/project_export_presenter.rb
+0
-1
config/sidekiq_queues.yml
config/sidekiq_queues.yml
+2
-3
ee/app/finders/security/pipeline_vulnerabilities_finder.rb
ee/app/finders/security/pipeline_vulnerabilities_finder.rb
+0
-1
lib/gitlab/branch_push_merge_commit_analyzer.rb
lib/gitlab/branch_push_merge_commit_analyzer.rb
+1
-1
lib/gitlab/ci/templates/dotNET.gitlab-ci.yml
lib/gitlab/ci/templates/dotNET.gitlab-ci.yml
+1
-1
lib/gitlab/ci/trace/stream.rb
lib/gitlab/ci/trace/stream.rb
+0
-1
lib/gitlab/git.rb
lib/gitlab/git.rb
+0
-1
lib/support/logrotate/gitlab
lib/support/logrotate/gitlab
+0
-1
lib/tasks/gitlab/sidekiq.rake
lib/tasks/gitlab/sidekiq.rake
+2
-3
spec/support/helpers/bare_repo_operations.rb
spec/support/helpers/bare_repo_operations.rb
+0
-1
No files found.
app/presenters/projects/import_export/project_export_presenter.rb
View file @
b92c6d36
...
...
@@ -34,7 +34,6 @@ module Projects
# We need `.connected_to_user` here otherwise when a group has an
# invitee, it would make the following query return 0 rows since a NULL
# user_id would be present in the subquery
# See http://stackoverflow.com/questions/129077/not-in-clause-and-null-values
non_null_user_ids
=
project
.
project_members
.
connected_to_user
.
select
(
:user_id
)
GroupMembersFinder
.
new
(
project
.
group
).
execute
.
where
.
not
(
user_id:
non_null_user_ids
)
end
...
...
config/sidekiq_queues.yml
View file @
b92c6d36
...
...
@@ -17,9 +17,8 @@
# 3: high priority
# 5: _super_ high priority, this should only be used for _very_ important queues
#
# As per http://stackoverflow.com/a/21241357/290102 the formula for calculating
# the likelihood of a job being popped off a queue (given all queues have work
# to perform) is:
# The formula for calculating the likelihood of a job being popped off a queue
# (given all queues have work to perform) is:
#
# chance = (queue weight / total weight of all queues) * 100
---
...
...
ee/app/finders/security/pipeline_vulnerabilities_finder.rb
View file @
b92c6d36
...
...
@@ -53,7 +53,6 @@ module Security
# environment.
# This is easier to address from within the class rather than from tests because this leads to bad class design
# and exposing too much of its implementation details to the test suite.
# See also https://stackoverflow.com/questions/15442298/is-sort-in-ruby-stable.
Gitlab
::
Utils
.
stable_sort_by
(
findings
)
{
|
x
|
[
-
x
.
severity_value
,
-
x
.
confidence_value
]
}
end
...
...
lib/gitlab/branch_push_merge_commit_analyzer.rb
View file @
b92c6d36
...
...
@@ -114,7 +114,7 @@ module Gitlab
# If child commit is a direct ancestor, its first parent is also a direct ancestor.
# We assume direct ancestors matches the trail of the target branch over time,
# This assumption is correct most of the time, especially for gitlab managed merges,
# but there are exception cases which can't be solved
(https://stackoverflow.com/a/49754723/474597)
# but there are exception cases which can't be solved
.
def
mark_all_direct_ancestors
(
commit
)
loop
do
commit
=
get_commit
(
commit
.
parent_ids
.
first
)
...
...
lib/gitlab/ci/templates/dotNET.gitlab-ci.yml
View file @
b92c6d36
...
...
@@ -21,7 +21,7 @@
#
# The deploy stage copies the exe and msi from build stage to a network drive
# You need to have the network drive mapped as Local System user for gitlab-runner service to see it
# The best way to persist the mapping is via a scheduled task
(see: https://stackoverflow.com/a/7867064/1288473),
# The best way to persist the mapping is via a scheduled task
# running the following batch command: net use P: \\x.x.x.x\Projects /u:your_user your_pass /persistent:yes
# place project specific paths in variables to make the rest of the script more generic
...
...
lib/gitlab/ci/trace/stream.rb
View file @
b92c6d36
...
...
@@ -3,7 +3,6 @@
module
Gitlab
module
Ci
class
Trace
# This was inspired from: http://stackoverflow.com/a/10219411/1520132
class
Stream
BUFFER_SIZE
=
4096
LIMIT_SIZE
=
500
.
kilobytes
...
...
lib/gitlab/git.rb
View file @
b92c6d36
...
...
@@ -5,7 +5,6 @@ require_dependency 'gitlab/encoding_helper'
module
Gitlab
module
Git
# The ID of empty tree.
# See http://stackoverflow.com/a/40884093/1856239 and
# https://github.com/git/git/blob/3ad8b5bf26362ac67c9020bf8c30eee54a84f56d/cache.h#L1011-L1012
EMPTY_TREE_ID
=
'4b825dc642cb6eb9a060e54bf8d69288fbee4904'
BLANK_SHA
=
(
'0'
*
40
).
freeze
...
...
lib/support/logrotate/gitlab
View file @
b92c6d36
# GitLab logrotate settings
# based on: http://stackoverflow.com/a/4883967
/home/git/gitlab/log/*.log {
su git git
...
...
lib/tasks/gitlab/sidekiq.rake
View file @
b92c6d36
...
...
@@ -86,9 +86,8 @@ namespace :gitlab do
# 3: high priority
# 5: _super_ high priority, this should only be used for _very_ important queues
#
# As per http://stackoverflow.com/a/21241357/290102 the formula for calculating
# the likelihood of a job being popped off a queue (given all queues have work
# to perform) is:
# The formula for calculating the likelihood of a job being popped off a queue
# (given all queues have work to perform) is:
#
# chance = (queue weight / total weight of all queues) * 100
BANNER
...
...
spec/support/helpers/bare_repo_operations.rb
View file @
b92c6d36
...
...
@@ -17,7 +17,6 @@ class BareRepoOperations
commit_id
[
0
]
end
# Based on https://stackoverflow.com/a/25556917/1856239
def
commit_file
(
file
,
dst_path
,
branch
=
'master'
)
head_id
=
execute
([
'show'
,
'--format=format:%H'
,
'--no-patch'
,
branch
],
allow_failure:
true
)[
0
]
||
Gitlab
::
Git
::
EMPTY_TREE_ID
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment