Merge branch 'pl-error-tracking-length-validation' into 'master'

Add length validations for error tracking errors and events

See merge request gitlab-org/gitlab!74012

app/models/error_tracking/error.rb

@@ -18,9 +18,10 @@ class ErrorTracking::Error < ApplicationRecord
   scope :for_status, -> (status) { where(status: status) }
 
   validates :project, presence: true
-  validates :name, presence: true
-  validates :description, presence: true
-  validates :actor, presence: true
+  validates :name, presence: true, length: { maximum: 255 }
+  validates :description, presence: true, length: { maximum: 1024 }
+  validates :actor, presence: true, length: { maximum: 255 }
+  validates :platform, length: { maximum: 255 }
   validates :status, presence: true
 
   enum status: {

app/models/error_tracking/error_event.rb

@@ -6,7 +6,9 @@ class ErrorTracking::ErrorEvent < ApplicationRecord
   validates :payload, json_schema: { filename: 'error_tracking_event_payload' }
 
   validates :error, presence: true
-  validates :description, presence: true
+  validates :description, presence: true, length: { maximum: 1024 }
+  validates :level, length: { maximum: 255 }
+  validates :environment, length: { maximum: 255 }
   validates :occurred_at, presence: true
 
   def stacktrace

spec/models/error_tracking/error_event_spec.rb

@@ -11,7 +11,10 @@ RSpec.describe ErrorTracking::ErrorEvent, type: :model do
 
   describe 'validations' do
     it { is_expected.to validate_presence_of(:description) }
+    it { is_expected.to validate_length_of(:description).is_at_most(1024) }
     it { is_expected.to validate_presence_of(:occurred_at) }
+    it { is_expected.to validate_length_of(:level).is_at_most(255) }
+    it { is_expected.to validate_length_of(:environment).is_at_most(255) }
   end
 
   describe '#stacktrace' do

spec/models/error_tracking/error_spec.rb

@@ -12,8 +12,12 @@ RSpec.describe ErrorTracking::Error, type: :model do
 
   describe 'validations' do
     it { is_expected.to validate_presence_of(:name) }
+    it { is_expected.to validate_length_of(:name).is_at_most(255) }
     it { is_expected.to validate_presence_of(:description) }
+    it { is_expected.to validate_length_of(:description).is_at_most(1024) }
     it { is_expected.to validate_presence_of(:actor) }
+    it { is_expected.to validate_length_of(:actor).is_at_most(255) }
+    it { is_expected.to validate_length_of(:platform).is_at_most(255) }
   end
 
   describe '.report_error' do