Commit c15dc455 authored by Grzegorz Bizon's avatar Grzegorz Bizon

Move and improvement comment in pipeline fixtures

parent 7450fe78
...@@ -74,6 +74,10 @@ class Gitlab::Seeder::Pipelines ...@@ -74,6 +74,10 @@ class Gitlab::Seeder::Pipelines
.merge(commands: '$ build command') .merge(commands: '$ build command')
Ci::Build.create!(attributes).tap do |build| Ci::Build.create!(attributes).tap do |build|
# We need to set build trace and artifacts after saving a build
# (id required), that is why we need `#tap` method instead of passing
# block directly to `Ci::Build#create!`.
setup_artifacts(build) setup_artifacts(build)
setup_build_log(build) setup_build_log(build)
build.save build.save
...@@ -93,11 +97,6 @@ class Gitlab::Seeder::Pipelines ...@@ -93,11 +97,6 @@ class Gitlab::Seeder::Pipelines
end end
def setup_build_log(build) def setup_build_log(build)
##
# We need to set build trace after saving a build (id required)
# That is why we need `#tap` method instead of passing block
# directly to `Ci::Build#create!`.
#
if %w(running success failed).include?(build.status) if %w(running success failed).include?(build.status)
build.trace = FFaker::Lorem.paragraphs(6).join("\n\n") build.trace = FFaker::Lorem.paragraphs(6).join("\n\n")
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment