Commit c2c989d9 authored by Nicolò Maria Mezzopera's avatar Nicolò Maria Mezzopera

Merge branch '345385-add-space-between-columns-in-runner-table' into 'master'

Add space between columns in runner table

See merge request gitlab-org/gitlab!75636
parents e30d909d 6f1fbc24
...@@ -9,20 +9,17 @@ import RunnerSummaryCell from './cells/runner_summary_cell.vue'; ...@@ -9,20 +9,17 @@ import RunnerSummaryCell from './cells/runner_summary_cell.vue';
import RunnerStatusCell from './cells/runner_status_cell.vue'; import RunnerStatusCell from './cells/runner_status_cell.vue';
import RunnerTags from './runner_tags.vue'; import RunnerTags from './runner_tags.vue';
const tableField = ({ key, label = '', width = 10 }) => { const tableField = ({ key, label = '', thClasses = [] }) => {
return { return {
key, key,
label, label,
thClass: [ thClass: [
`gl-w-${width}p`,
'gl-bg-transparent!', 'gl-bg-transparent!',
'gl-border-b-solid!', 'gl-border-b-solid!',
'gl-border-b-gray-100!', 'gl-border-b-gray-100!',
'gl-py-5!',
'gl-px-0!',
'gl-border-b-1!', 'gl-border-b-1!',
...thClasses,
], ],
tdClass: ['gl-py-5!', 'gl-px-1!'],
tdAttr: { tdAttr: {
'data-testid': `td-${key}`, 'data-testid': `td-${key}`,
}, },
...@@ -66,10 +63,10 @@ export default { ...@@ -66,10 +63,10 @@ export default {
}, },
fields: [ fields: [
tableField({ key: 'status', label: s__('Runners|Status') }), tableField({ key: 'status', label: s__('Runners|Status') }),
tableField({ key: 'summary', label: s__('Runners|Runner ID'), width: 30 }), tableField({ key: 'summary', label: s__('Runners|Runner ID'), thClasses: ['gl-lg-w-25p'] }),
tableField({ key: 'version', label: __('Version') }), tableField({ key: 'version', label: __('Version') }),
tableField({ key: 'ipAddress', label: __('IP Address') }), tableField({ key: 'ipAddress', label: __('IP Address') }),
tableField({ key: 'tagList', label: __('Tags'), width: 20 }), tableField({ key: 'tagList', label: __('Tags'), thClasses: ['gl-lg-w-25p'] }),
tableField({ key: 'contactedAt', label: __('Last contact') }), tableField({ key: 'contactedAt', label: __('Last contact') }),
tableField({ key: 'actions', label: '' }), tableField({ key: 'actions', label: '' }),
], ],
......
...@@ -302,3 +302,10 @@ $gl-line-height-42: px-to-rem(42px); ...@@ -302,3 +302,10 @@ $gl-line-height-42: px-to-rem(42px);
.gl-z-index-200 { .gl-z-index-200 {
z-index: 200; z-index: 200;
} }
// Will be moved to @gitlab/ui by https://gitlab.com/gitlab-org/gitlab-ui/-/issues/1637
.gl-lg-w-25p {
@include gl-media-breakpoint-up(lg) {
width: 25%;
}
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment