Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c2fedfb3
Commit
c2fedfb3
authored
Feb 14, 2020
by
Martin Wortschack
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add badge tooltips for hidden approvers
parent
0a8d441b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
3 deletions
+9
-3
ee/app/assets/javascripts/analytics/code_review_analytics/components/approvers_column.vue
...ics/code_review_analytics/components/approvers_column.vue
+3
-0
ee/spec/frontend/analytics/code_review_analytics/components/__snapshots__/approvers_column_spec.js.snap
...cs/components/__snapshots__/approvers_column_spec.js.snap
+6
-3
No files found.
ee/app/assets/javascripts/analytics/code_review_analytics/components/approvers_column.vue
View file @
c2fedfb3
...
...
@@ -38,6 +38,7 @@ export default {
},
},
avatarSize
:
24
,
badgeTooltipMaxChars
:
50
,
};
</
script
>
...
...
@@ -49,6 +50,8 @@ export default {
:avatars=
"approvers"
:max-visible=
"maxVisible"
:avatar-size=
"$options.avatarSize"
badge-tooltip-prop=
"name"
:badge-tooltip-max-chars=
"$options.badgeTooltipMaxChars"
>
<template
#avatar
="
{ avatar }">
<gl-avatar-link
v-gl-tooltip
target=
"_blank"
:href=
"avatar.web_url"
:title=
"avatar.name"
>
...
...
ee/spec/frontend/analytics/code_review_analytics/components/__snapshots__/approvers_column_spec.js.snap
View file @
c2fedfb3
...
...
@@ -5,7 +5,8 @@ exports[`ApproversColumn component when a list with more than three approvers is
<gl-avatars-inline-stub
avatars="[object Object],[object Object],[object Object],[object Object]"
avatarsize="24"
badgetooltipprop=""
badgetooltipmaxchars="50"
badgetooltipprop="name"
collapsed="true"
maxvisible="2"
/>
...
...
@@ -36,7 +37,8 @@ exports[`ApproversColumn component when a list with three approvers is passed ma
<gl-avatars-inline-stub
avatars="[object Object],[object Object],[object Object]"
avatarsize="24"
badgetooltipprop=""
badgetooltipmaxchars="50"
badgetooltipprop="name"
collapsed="true"
maxvisible="3"
/>
...
...
@@ -48,7 +50,8 @@ exports[`ApproversColumn component when a list with two approvers is passed matc
<gl-avatars-inline-stub
avatars="[object Object],[object Object]"
avatarsize="24"
badgetooltipprop=""
badgetooltipmaxchars="50"
badgetooltipprop="name"
collapsed="true"
maxvisible="3"
/>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment