Add specs and changelog for packages fix

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

ee/changelogs/unreleased/8316-maven-package-permissions-option-wrongly-available-in-starter.yml

+---
+title: Don't show packages tab and settings for starter license
+merge_request: 8270
+author:
+type: fixed

ee/spec/features/projects/settings/packages_settings_spec.rb

@@ -14,6 +14,11 @@ describe 'Projects > Settings > Packages', :js do
       allow(Gitlab.config.packages).to receive(:enabled).and_return(true)
     end
 
+    context 'allowed by license' do
+      before do
+        stub_licensed_features(packages: true)
+      end
+
       it 'displays the packages toggle button' do
         visit edit_project_path(project)
 
@@ -22,6 +27,19 @@ describe 'Projects > Settings > Packages', :js do
       end
     end
 
+    context 'not allowed by license' do
+      before do
+        stub_licensed_features(packages: false)
+      end
+
+      it 'does not show up in UI' do
+        visit edit_project_path(project)
+
+        expect(page).not_to have_content('Packages')
+      end
+    end
+  end
+
   context 'Packages disabled in config' do
     before do
       allow(Gitlab.config.packages).to receive(:enabled).and_return(false)

spec/features/projects/features_visibility_spec.rb

@@ -177,7 +177,7 @@ describe 'Edit Project Settings' do
         click_button "Save changes"
       end
 
-      expect(find(".sharing-permissions")).to have_selector(".project-feature-toggle.is-disabled", count: 3)
+      expect(find(".sharing-permissions")).to have_selector(".project-feature-toggle.is-disabled", count: 2)
     end
 
     it "shows empty features project homepage" do