Commit c48f0c1a authored by Phil Hughes's avatar Phil Hughes

Added specs to isDiscussionApplicableToLine

It now tests for the latest diff check
parent 5c39c7c3
...@@ -350,13 +350,13 @@ describe('DiffsStoreUtils', () => { ...@@ -350,13 +350,13 @@ describe('DiffsStoreUtils', () => {
it('returns true when the discussion is up to date', () => { it('returns true when the discussion is up to date', () => {
expect( expect(
utils.isDiscussionApplicableToLine(discussions.upToDateDiscussion1, diffPosition), utils.isDiscussionApplicableToLine(discussions.upToDateDiscussion1, diffPosition, true),
).toBe(true); ).toBe(true);
}); });
it('returns false when the discussion is not up to date', () => { it('returns false when the discussion is not up to date', () => {
expect( expect(
utils.isDiscussionApplicableToLine(discussions.outDatedDiscussion1, diffPosition), utils.isDiscussionApplicableToLine(discussions.outDatedDiscussion1, diffPosition, true),
).toBe(false); ).toBe(false);
}); });
...@@ -366,10 +366,14 @@ describe('DiffsStoreUtils', () => { ...@@ -366,10 +366,14 @@ describe('DiffsStoreUtils', () => {
delete discussion.position; delete discussion.position;
expect( expect(
utils.isDiscussionApplicableToLine(discussion, { utils.isDiscussionApplicableToLine(
...diffPosition, discussion,
lineCode: 'ABC_1', {
}), ...diffPosition,
lineCode: 'ABC_1',
},
true,
),
).toBe(false); ).toBe(false);
}); });
...@@ -379,11 +383,32 @@ describe('DiffsStoreUtils', () => { ...@@ -379,11 +383,32 @@ describe('DiffsStoreUtils', () => {
delete discussion.position; delete discussion.position;
expect( expect(
utils.isDiscussionApplicableToLine(discussion, { utils.isDiscussionApplicableToLine(
...diffPosition, discussion,
lineCode: 'ABC_1', {
}), ...diffPosition,
lineCode: 'ABC_1',
},
true,
),
).toBe(true); ).toBe(true);
}); });
it('returns false when not latest diff', () => {
const discussion = { ...discussions.outDatedDiscussion1, line_code: 'ABC_1', active: true };
delete discussion.original_position;
delete discussion.position;
expect(
utils.isDiscussionApplicableToLine(
discussion,
{
...diffPosition,
lineCode: 'ABC_1',
},
false,
),
).toBe(false);
});
}); });
}); });
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment