Merge branch 'pks-gitaly-commits-between-via-list-commits' into 'master'

gitaly_client: Reimplement `#between` via `#list_commits`

See merge request gitlab-org/gitlab!74273

config/feature_flags/development/between_commits_via_list_commits.yml

+---
+name: between_commits_via_list_commits
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/74273
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/345458
+milestone: '14.5'
+type: development
+group: group::gitaly
+default_enabled: false

lib/gitlab/gitaly_client/commit_service.rb

@@ -205,6 +205,8 @@ module Gitlab
       end
 
       def between(from, to)
+        return list_commits(["^" + from, to], reverse: true) if Feature.enabled?(:between_commits_via_list_commits)
+
         request = Gitaly::CommitsBetweenRequest.new(
           repository: @gitaly_repo,
           from: from,

spec/lib/gitlab/gitaly_client/commit_service_spec.rb

@@ -112,15 +112,38 @@ RSpec.describe Gitlab::GitalyClient::CommitService do
     let(:from) { 'master' }
     let(:to) { Gitlab::Git::EMPTY_TREE_ID }
 
-    it 'sends an RPC request' do
-      request = Gitaly::CommitsBetweenRequest.new(
-        repository: repository_message, from: from, to: to
-      )
+    context 'with between_commits_via_list_commits enabled' do
+      before do
+        stub_feature_flags(between_commits_via_list_commits: true)
+      end
 
-      expect_any_instance_of(Gitaly::CommitService::Stub).to receive(:commits_between)
-        .with(request, kind_of(Hash)).and_return([])
+      it 'sends an RPC request' do
+        request = Gitaly::ListCommitsRequest.new(
+          repository: repository_message, revisions: ["^" + from, to], reverse: true
+        )
+
+        expect_any_instance_of(Gitaly::CommitService::Stub).to receive(:list_commits)
+          .with(request, kind_of(Hash)).and_return([])
 
-      described_class.new(repository).between(from, to)
+        described_class.new(repository).between(from, to)
+      end
+    end
+
+    context 'with between_commits_via_list_commits disabled' do
+      before do
+        stub_feature_flags(between_commits_via_list_commits: false)
+      end
+
+      it 'sends an RPC request' do
+        request = Gitaly::CommitsBetweenRequest.new(
+          repository: repository_message, from: from, to: to
+        )
+
+        expect_any_instance_of(Gitaly::CommitService::Stub).to receive(:commits_between)
+          .with(request, kind_of(Hash)).and_return([])
+
+        described_class.new(repository).between(from, to)
+      end
     end
   end