Bootstrap applications without DOMContentLoaded

This MR deprecates the uses of DOMContentLoaded in
groups/issues/index.js
projects/issues/index/index.js
projects/issues/new/index.js
projects/issues/service_desk/index.js
projects/issues/show/index.js
ee/../projects/issues/show/index.js

app/assets/javascripts/pages/groups/issues/index.js

@@ -8,18 +8,16 @@ import initManualOrdering from '~/manual_ordering';
 
 const ISSUE_BULK_UPDATE_PREFIX = 'issue_';
 
-document.addEventListener('DOMContentLoaded', () => {
-  IssuableFilteredSearchTokenKeys.addExtraTokensForIssues();
-  issuableInitBulkUpdateSidebar.init(ISSUE_BULK_UPDATE_PREFIX);
+IssuableFilteredSearchTokenKeys.addExtraTokensForIssues();
+issuableInitBulkUpdateSidebar.init(ISSUE_BULK_UPDATE_PREFIX);
 
-  initIssuablesList();
+initIssuablesList();
 
-  initFilteredSearch({
-    page: FILTERED_SEARCH.ISSUES,
-    isGroupDecendent: true,
-    useDefaultState: true,
-    filteredSearchTokenKeys: IssuableFilteredSearchTokenKeys,
-  });
-  projectSelect();
-  initManualOrdering();
+initFilteredSearch({
+  page: FILTERED_SEARCH.ISSUES,
+  isGroupDecendent: true,
+  useDefaultState: true,
+  filteredSearchTokenKeys: IssuableFilteredSearchTokenKeys,
 });
+projectSelect();
+initManualOrdering();

app/assets/javascripts/pages/projects/issues/index/index.js

@@ -11,20 +11,18 @@ import initIssuablesList from '~/issues_list';
 import initManualOrdering from '~/manual_ordering';
 import { showLearnGitLabIssuesPopover } from '~/onboarding_issues';
 
-document.addEventListener('DOMContentLoaded', () => {
-  IssuableFilteredSearchTokenKeys.addExtraTokensForIssues();
+IssuableFilteredSearchTokenKeys.addExtraTokensForIssues();
 
-  initFilteredSearch({
-    page: FILTERED_SEARCH.ISSUES,
-    filteredSearchTokenKeys: IssuableFilteredSearchTokenKeys,
-    useDefaultState: true,
-  });
+initFilteredSearch({
+  page: FILTERED_SEARCH.ISSUES,
+  filteredSearchTokenKeys: IssuableFilteredSearchTokenKeys,
+  useDefaultState: true,
+});
 
-  new IssuableIndex(ISSUABLE_INDEX.ISSUE);
-  new ShortcutsNavigation();
-  new UsersSelect();
+new IssuableIndex(ISSUABLE_INDEX.ISSUE);
+new ShortcutsNavigation();
+new UsersSelect();
 
-  initManualOrdering();
-  initIssuablesList();
-  showLearnGitLabIssuesPopover();
-});
+initManualOrdering();
+initIssuablesList();
+showLearnGitLabIssuesPopover();

app/assets/javascripts/pages/projects/issues/new/index.js

 import initForm from 'ee_else_ce/pages/projects/issues/form';
 
-document.addEventListener('DOMContentLoaded', initForm);
+initForm();

app/assets/javascripts/pages/projects/issues/service_desk/index.js

 import FilteredSearchServiceDesk from './filtered_search';
 import initIssuablesList from '~/issues_list';
 
-document.addEventListener('DOMContentLoaded', () => {
-  const supportBotData = JSON.parse(
-    document.querySelector('.js-service-desk-issues').dataset.supportBot,
-  );
+const supportBotData = JSON.parse(
+  document.querySelector('.js-service-desk-issues').dataset.supportBot,
+);
 
-  if (document.querySelector('.filtered-search')) {
-    const filteredSearchManager = new FilteredSearchServiceDesk(supportBotData);
-    filteredSearchManager.setup();
-  }
+if (document.querySelector('.filtered-search')) {
+  const filteredSearchManager = new FilteredSearchServiceDesk(supportBotData);
+  filteredSearchManager.setup();
+}
 
-  if (gon.features?.vueIssuablesList) {
-    initIssuablesList();
-  }
-});
+if (gon.features?.vueIssuablesList) {
+  initIssuablesList();
+}

app/assets/javascripts/pages/projects/issues/show/index.js

@@ -2,10 +2,8 @@ import initSidebarBundle from '~/sidebar/sidebar_bundle';
 import initRelatedIssues from '~/related_issues';
 import initShow from '../show';
 
-document.addEventListener('DOMContentLoaded', () => {
-  initShow();
-  if (gon.features && !gon.features.vueIssuableSidebar) {
-    initSidebarBundle();
-  }
-  initRelatedIssues();
-});
+initShow();
+if (gon.features && !gon.features.vueIssuableSidebar) {
+  initSidebarBundle();
+}
+initRelatedIssues();

ee/app/assets/javascripts/pages/projects/issues/show/index.js

@@ -4,19 +4,17 @@ import initRelatedIssues from '~/related_issues';
 import initShow from '~/pages/projects/issues/show';
 import UserCallout from '~/user_callout';
 
-document.addEventListener('DOMContentLoaded', () => {
-  initShow();
-  if (gon.features && !gon.features.vueIssuableSidebar) {
-    initSidebarBundle();
-  }
-  initRelatedIssues();
+initShow();
+if (gon.features && !gon.features.vueIssuableSidebar) {
+  initSidebarBundle();
+}
+initRelatedIssues();
 
-  // eslint-disable-next-line no-new
-  new UserCallout({ className: 'js-epics-sidebar-callout' });
-  // eslint-disable-next-line no-new
-  new UserCallout({ className: 'js-weight-sidebar-callout' });
+// eslint-disable-next-line no-new
+new UserCallout({ className: 'js-epics-sidebar-callout' });
+// eslint-disable-next-line no-new
+new UserCallout({ className: 'js-weight-sidebar-callout' });
 
-  const assigneeDropdown = document.querySelector('.js-sidebar-assignee-dropdown');
+const assigneeDropdown = document.querySelector('.js-sidebar-assignee-dropdown');
 
-  if (assigneeDropdown) trackShowInviteMemberLink(assigneeDropdown);
-});
+if (assigneeDropdown) trackShowInviteMemberLink(assigneeDropdown);