Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c5516906
Commit
c5516906
authored
Sep 27, 2021
by
Maxime Orefice
Committed by
Douglas Barbosa Alexandre
Sep 27, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove usage_data_i_testing_group_code_coverage_visit_total feature flag
parent
bb3fe4a1
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
1 addition
and
28 deletions
+1
-28
config/feature_flags/development/usage_data_i_testing_group_code_coverage_visit_total.yml
.../usage_data_i_testing_group_code_coverage_visit_total.yml
+0
-8
ee/app/assets/javascripts/analytics/repository_analytics/components/group_repository_analytics.vue
...itory_analytics/components/group_repository_analytics.vue
+1
-6
ee/app/controllers/groups/analytics/repository_analytics_controller.rb
...llers/groups/analytics/repository_analytics_controller.rb
+0
-3
ee/spec/frontend/analytics/repository_analytics/components/group_repository_analytics_spec.js
...y_analytics/components/group_repository_analytics_spec.js
+0
-10
lib/gitlab/usage_data_counters/known_events/common.yml
lib/gitlab/usage_data_counters/known_events/common.yml
+0
-1
No files found.
config/feature_flags/development/usage_data_i_testing_group_code_coverage_visit_total.yml
deleted
100644 → 0
View file @
bb3fe4a1
---
name
:
usage_data_i_testing_group_code_coverage_visit_total
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/51382
rollout_issue_url
:
milestone
:
'
13.8'
type
:
development
group
:
group::testing
default_enabled
:
true
ee/app/assets/javascripts/analytics/repository_analytics/components/group_repository_analytics.vue
View file @
c5516906
<
script
>
import
Api
from
'
~/api
'
;
import
{
s__
}
from
'
~/locale
'
;
import
glFeatureFlagsMixin
from
'
~/vue_shared/mixins/gl_feature_flags_mixin
'
;
import
DownloadTestCoverage
from
'
./download_test_coverage.vue
'
;
import
TestCoverageSummary
from
'
./test_coverage_summary.vue
'
;
import
TestCoverageTable
from
'
./test_coverage_table.vue
'
;
export
const
VISIT_EVENT_FEATURE_FLAG
=
'
usageDataITestingGroupCodeCoverageVisitTotal
'
;
export
const
VISIT_EVENT_NAME
=
'
i_testing_group_code_coverage_visit_total
'
;
export
default
{
...
...
@@ -16,11 +14,8 @@ export default {
TestCoverageTable
,
DownloadTestCoverage
,
},
mixins
:
[
glFeatureFlagsMixin
()],
mounted
()
{
if
(
this
.
glFeatures
[
VISIT_EVENT_FEATURE_FLAG
])
{
Api
.
trackRedisHllUserEvent
(
VISIT_EVENT_NAME
);
}
Api
.
trackRedisHllUserEvent
(
VISIT_EVENT_NAME
);
},
text
:
{
codeCoverageHeader
:
s__
(
'
RepositoriesAnalytics|Test Code Coverage
'
),
...
...
ee/app/controllers/groups/analytics/repository_analytics_controller.rb
View file @
c5516906
...
...
@@ -5,9 +5,6 @@ class Groups::Analytics::RepositoryAnalyticsController < Groups::Analytics::Appl
before_action
:load_group
before_action
->
{
authorize_view_by_action!
(
:read_group_repository_analytics
)
}
before_action
only:
[
:show
]
do
push_frontend_feature_flag
(
:usage_data_i_testing_group_code_coverage_visit_total
,
@group
,
default_enabled: :yaml
)
end
def
show
Gitlab
::
Tracking
.
event
(
self
.
class
.
name
,
'show'
,
**
pageview_tracker_params
)
...
...
ee/spec/frontend/analytics/repository_analytics/components/group_repository_analytics_spec.js
View file @
c5516906
...
...
@@ -46,15 +46,5 @@ describe('Group repository analytics app', () => {
expect
(
Api
.
trackRedisHllUserEvent
).
toHaveBeenCalledWith
(
VISIT_EVENT_NAME
);
});
});
describe
(
'
with the feature flag disabled
'
,
()
=>
{
beforeEach
(()
=>
{
createComponent
({
[
VISIT_EVENT_FEATURE_FLAG
]:
false
});
});
it
(
'
does not track a visit event on mount
'
,
()
=>
{
expect
(
Api
.
trackRedisHllUserEvent
).
not
.
toHaveBeenCalled
();
});
});
});
});
lib/gitlab/usage_data_counters/known_events/common.yml
View file @
c5516906
...
...
@@ -158,7 +158,6 @@
category
:
testing
redis_slot
:
testing
aggregation
:
weekly
feature_flag
:
usage_data_i_testing_group_code_coverage_visit_total
-
name
:
i_testing_full_code_quality_report_total
category
:
testing
redis_slot
:
testing
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment