Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c7d293f0
Commit
c7d293f0
authored
Sep 06, 2021
by
David Kim
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Release diffs_batch cached rendering
Changelog: performance
parent
44cc8d9f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
9 deletions
+1
-9
app/controllers/projects/merge_requests/diffs_controller.rb
app/controllers/projects/merge_requests/diffs_controller.rb
+1
-1
config/feature_flags/development/diffs_batch_render_cached.yml
...g/feature_flags/development/diffs_batch_render_cached.yml
+0
-8
No files found.
app/controllers/projects/merge_requests/diffs_controller.rb
View file @
c7d293f0
...
@@ -42,7 +42,7 @@ class Projects::MergeRequests::DiffsController < Projects::MergeRequests::Applic
...
@@ -42,7 +42,7 @@ class Projects::MergeRequests::DiffsController < Projects::MergeRequests::Applic
allow_tree_conflicts:
display_merge_conflicts_in_diff?
allow_tree_conflicts:
display_merge_conflicts_in_diff?
}
}
if
diff_options_hash
[
:paths
].
blank?
&&
Feature
.
enabled?
(
:diffs_batch_render_cached
,
project
,
default_enabled: :yaml
)
if
diff_options_hash
[
:paths
].
blank?
# NOTE: Any variables that would affect the resulting json needs to be added to the cache_context to avoid stale cache issues.
# NOTE: Any variables that would affect the resulting json needs to be added to the cache_context to avoid stale cache issues.
cache_context
=
[
cache_context
=
[
current_user
&
.
cache_key
,
current_user
&
.
cache_key
,
...
...
config/feature_flags/development/diffs_batch_render_cached.yml
deleted
100644 → 0
View file @
44cc8d9f
---
name
:
diffs_batch_render_cached
introduced_by_url
:
https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/1509
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/334762
milestone
:
'
14.1'
type
:
development
group
:
group::code review
default_enabled
:
false
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment