Merge branch 'allowlist_tick_for' into 'master'

Allow tick_for callsite

See merge request gitlab-org/gitlab!69623

app/services/ci/update_build_queue_service.rb

@@ -99,15 +99,17 @@ module Ci
     private
 
     def tick_for(build, runners)
-      runners = runners.with_recent_runner_queue
-      runners = runners.with_tags if Feature.enabled?(:ci_preload_runner_tags, default_enabled: :yaml)
+      ::Gitlab::Database.allow_cross_joins_across_databases(url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/339937') do
+        runners = runners.with_recent_runner_queue
+        runners = runners.with_tags if Feature.enabled?(:ci_preload_runner_tags, default_enabled: :yaml)
 
-      metrics.observe_active_runners(-> { runners.to_a.size })
+        metrics.observe_active_runners(-> { runners.to_a.size })
 
-      runners.each do |runner|
-        metrics.increment_runner_tick(runner)
+        runners.each do |runner|
+          metrics.increment_runner_tick(runner)
 
-        runner.pick_build!(build)
+          runner.pick_build!(build)
+        end
       end
     end
 

spec/support/database/cross-join-allowlist.yml

@@ -329,7 +329,6 @@
 - "./spec/services/ci/play_build_service_spec.rb"
 - "./spec/services/ci/register_job_service_spec.rb"
 - "./spec/services/ci/retry_pipeline_service_spec.rb"
-- "./spec/services/ci/update_build_queue_service_spec.rb"
 - "./spec/services/clusters/applications/prometheus_config_service_spec.rb"
 - "./spec/services/deployments/older_deployments_drop_service_spec.rb"
 - "./spec/services/environments/auto_stop_service_spec.rb"