Commit c8e0327e authored by Rémy Coutable's avatar Rémy Coutable Committed by Albert Salim

danger: Post message about auto update of MR title when add/remove a FF

Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
parent ad576c0c
...@@ -52,12 +52,15 @@ def message_for_feature_flag_with_group!(feature_flag:, mr_group_label:) ...@@ -52,12 +52,15 @@ def message_for_feature_flag_with_group!(feature_flag:, mr_group_label:)
end end
end end
def feature_flag_file_added_or_removed?
feature_flag.feature_flag_files(change_type: :added).any? || feature_flag.feature_flag_files(change_type: :deleted).any?
end
feature_flag.feature_flag_files(change_type: :added).each do |feature_flag| feature_flag.feature_flag_files(change_type: :added).each do |feature_flag|
check_feature_flag_yaml(feature_flag) check_feature_flag_yaml(feature_flag)
end end
if feature_flag.feature_flag_files(change_type: :added).any? || if feature_flag_file_added_or_removed?
feature_flag.feature_flag_files(change_type: :deleted).any?
new_mr_title = helper.mr_title.dup new_mr_title = helper.mr_title.dup
new_mr_title << ' [RUN ALL RSPEC]' unless helper.run_all_rspec_mr? new_mr_title << ' [RUN ALL RSPEC]' unless helper.run_all_rspec_mr?
new_mr_title << ' [RUN AS-IF-FOSS]' unless helper.run_as_if_foss_mr? new_mr_title << ' [RUN AS-IF-FOSS]' unless helper.run_as_if_foss_mr?
...@@ -69,6 +72,7 @@ if feature_flag.feature_flag_files(change_type: :added).any? || ...@@ -69,6 +72,7 @@ if feature_flag.feature_flag_files(change_type: :added).any? ||
title: new_mr_title title: new_mr_title
) )
gitlab.api.post("/projects/#{gitlab.mr_json['project_id']}/merge_requests/#{gitlab.mr_json['iid']}/pipelines") gitlab.api.post("/projects/#{gitlab.mr_json['project_id']}/merge_requests/#{gitlab.mr_json['iid']}/pipelines")
message %(You're adding or removing a feature flag, and your MR title didn't include `[RUN ALL RSPEC] [RUN AS-IF-FOSS]`, so we've updated it and started a new MR pipeline to ensure everything is covered.) else
message "You're adding or removing a feature flag, your MR title needs to include `[RUN ALL RSPEC] [RUN AS-IF-FOSS]` (we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered."
end end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment