Merge branch 'issue-6568-single-codebase-spec-controllers' into 'master'

Extracted EE specific lines from spec/controllers

See merge request gitlab-org/gitlab-ee!13217

ee/spec/controllers/groups_controller_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe GroupsController do
+  include ExternalAuthorizationServiceHelpers
+
+  let(:user) { create(:user) }
+
+  describe 'POST #create' do
+    context 'authorization' do
+      it 'allows an auditor with "can_create_group" set to true to create a group' do
+        sign_in(create(:user, :auditor, can_create_group: true))
+
+        expect do
+          post :create, params: { group: { name: 'new_group', path: "new_group" } }
+        end.to change { Group.count }.by(1)
+
+        expect(response).to have_gitlab_http_status(302)
+      end
+    end
+  end
+end

ee/spec/controllers/projects_controller_spec.rb

@@ -30,6 +30,20 @@ describe ProjectsController do
     end
   end
 
+  describe 'GET edit' do
+    it 'does not allow an auditor user to access the page' do
+      sign_in(create(:user, :auditor))
+
+      get :edit,
+          params: {
+            namespace_id: project.namespace.path,
+            id: project.path
+          }
+
+      expect(response).to have_gitlab_http_status(404)
+    end
+  end
+
   describe 'POST create' do
     let!(:params) do
       {

spec/controllers/autocomplete_controller_spec.rb

@@ -335,44 +335,6 @@ describe AutocompleteController do
         end
       end
     end
-
-    context 'GET award_emojis' do
-      let(:user2) { create(:user) }
-      let!(:award_emoji1) { create_list(:award_emoji, 2, user: user, name: 'thumbsup') }
-      let!(:award_emoji2) { create_list(:award_emoji, 1, user: user, name: 'thumbsdown') }
-      let!(:award_emoji3) { create_list(:award_emoji, 3, user: user, name: 'star') }
-      let!(:award_emoji4) { create_list(:award_emoji, 1, user: user, name: 'tea') }
-
-      context 'unauthorized user' do
-        it 'returns empty json' do
-          get :award_emojis
-
-          expect(json_response).to be_empty
-        end
-      end
-
-      context 'sign in as user without award emoji' do
-        it 'returns empty json' do
-          sign_in(user2)
-          get :award_emojis
-
-          expect(json_response).to be_empty
-        end
-      end
-
-      context 'sign in as user with award emoji' do
-        it 'returns json sorted by name count' do
-          sign_in(user)
-          get :award_emojis
-
-          expect(json_response.count).to eq 4
-          expect(json_response[0]).to match('name' => 'star')
-          expect(json_response[1]).to match('name' => 'thumbsup')
-          expect(json_response[2]).to match('name' => 'tea')
-          expect(json_response[3]).to match('name' => 'thumbsdown')
-        end
-      end
-    end
   end
 
   context 'GET award_emojis' do

spec/controllers/groups_controller_spec.rb

@@ -161,16 +161,6 @@ describe GroupsController do
 
         expect(response).to have_gitlab_http_status(302)
       end
-
-      it 'allows an auditor with "can_create_group" set to true to create a group' do
-        sign_in(create(:user, :auditor, can_create_group: true))
-
-        expect do
-          post :create, params: { group: { name: 'new_group', path: "new_group" } }
-        end.to change { Group.count }.by(1)
-
-        expect(response).to have_gitlab_http_status(302)
-      end
     end
 
     context 'when creating subgroups', :nested_groups do

spec/controllers/projects_controller_spec.rb

@@ -292,6 +292,18 @@ describe ProjectsController do
   end
 
   describe 'GET edit' do
+    it 'allows an admin user to access the page' do
+      sign_in(create(:user, :admin))
+
+      get :edit,
+          params: {
+            namespace_id: project.namespace.path,
+            id: project.path
+          }
+
+      expect(response).to have_gitlab_http_status(200)
+    end
+
     it 'sets the badge API endpoint' do
       sign_in(user)
       project.add_maintainer(user)
@@ -730,32 +742,6 @@ describe ProjectsController do
     end
   end
 
-  describe 'GET edit' do
-    it 'does not allow an auditor user to access the page' do
-      sign_in(create(:user, :auditor))
-
-      get :edit,
-          params: {
-            namespace_id: project.namespace.path,
-            id: project.path
-          }
-
-      expect(response).to have_gitlab_http_status(404)
-    end
-
-    it 'allows an admin user to access the page' do
-      sign_in(create(:user, :admin))
-
-      get :edit,
-          params: {
-            namespace_id: project.namespace.path,
-            id: project.path
-          }
-
-      expect(response).to have_gitlab_http_status(200)
-    end
-  end
-
   describe 'POST #preview_markdown' do
     before do
       sign_in(user)