Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
cb1ec031
Commit
cb1ec031
authored
Sep 28, 2020
by
Kamil Trzciński
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove `ci_update_queues_for_online_runners` ff
This feature flag is no longer needed.
parent
3fd9cc8a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
2 additions
and
25 deletions
+2
-25
app/services/ci/update_build_queue_service.rb
app/services/ci/update_build_queue_service.rb
+1
-3
config/feature_flags/development/ci_update_queues_for_online_runners.yml
...flags/development/ci_update_queues_for_online_runners.yml
+0
-7
spec/services/ci/update_build_queue_service_spec.rb
spec/services/ci/update_build_queue_service_spec.rb
+1
-15
No files found.
app/services/ci/update_build_queue_service.rb
View file @
cb1ec031
...
...
@@ -9,9 +9,7 @@ module Ci
private
def
tick_for
(
build
,
runners
)
if
Feature
.
enabled?
(
:ci_update_queues_for_online_runners
,
build
.
project
,
default_enabled:
true
)
runners
=
runners
.
with_recent_runner_queue
end
runners
=
runners
.
with_recent_runner_queue
runners
.
each
do
|
runner
|
runner
.
pick_build!
(
build
)
...
...
config/feature_flags/development/ci_update_queues_for_online_runners.yml
deleted
100644 → 0
View file @
3fd9cc8a
---
name
:
ci_update_queues_for_online_runners
introduced_by_url
:
rollout_issue_url
:
group
:
type
:
development
default_enabled
:
true
spec/services/ci/update_build_queue_service_spec.rb
View file @
cb1ec031
...
...
@@ -45,21 +45,7 @@ RSpec.describe Ci::UpdateBuildQueueService do
runner
.
update!
(
contacted_at:
Ci
::
Runner
.
recent_queue_deadline
)
end
context
'when ci_update_queues_for_online_runners is enabled'
do
before
do
stub_feature_flags
(
ci_update_queues_for_online_runners:
true
)
end
it_behaves_like
'does not refresh runner'
end
context
'when ci_update_queues_for_online_runners is disabled'
do
before
do
stub_feature_flags
(
ci_update_queues_for_online_runners:
false
)
end
it_behaves_like
'refreshes runner'
end
it_behaves_like
'does not refresh runner'
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment