Merge branch 'ml-qa-remove-unnecessary-debug-checks' into 'master'

Remove unnecessary debug status checks

See merge request gitlab-org/gitlab!21380

qa/qa/resource/base.rb

@@ -64,7 +64,7 @@ module QA
       end
 
       def visit!
-        Runtime::Logger.debug(%Q[Visiting #{self.class.name} at "#{web_url}"]) if Runtime::Env.debug?
+        Runtime::Logger.debug(%Q[Visiting #{self.class.name} at "#{web_url}"])
 
         Support::Retrier.retry_until do
           visit(web_url)

qa/qa/resource/user.rb

@@ -79,7 +79,7 @@ module QA
       def api_delete
         super
 
-        QA::Runtime::Logger.debug("Deleted user '#{username}'") if Runtime::Env.debug?
+        QA::Runtime::Logger.debug("Deleted user '#{username}'")
       end
 
       def api_delete_path

qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb

@@ -24,7 +24,7 @@ module QA
 
         # Wait for Action Mailer to deliver messages
         mailhog_json = Support::Retrier.retry_until(sleep_interval: 1) do
-          Runtime::Logger.debug(%Q[retrieving "#{QA::Runtime::MailHog.api_messages_url}"]) if Runtime::Env.debug?
+          Runtime::Logger.debug(%Q[retrieving "#{QA::Runtime::MailHog.api_messages_url}"])
 
           mailhog_response = get QA::Runtime::MailHog.api_messages_url
 

qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_sso_spec.rb

@@ -330,7 +330,7 @@ module QA
     end
 
     def reset_idp_session
-      Runtime::Logger.debug(%Q[Visiting IDP url at "#{EE::Runtime::Saml.idp_sso_url}"]) if Runtime::Env.debug?
+      Runtime::Logger.debug(%Q[Visiting IDP url at "#{EE::Runtime::Saml.idp_sso_url}"])
 
       page.visit EE::Runtime::Saml.idp_sso_url
       Support::Waiter.wait { current_url == EE::Runtime::Saml.idp_sso_url }
@@ -339,7 +339,7 @@ module QA
     end
 
     def visit_managed_group_url
-      Runtime::Logger.debug(%Q[Visiting managed_group_url at "#{@managed_group_url}"]) if Runtime::Env.debug?
+      Runtime::Logger.debug(%Q[Visiting managed_group_url at "#{@managed_group_url}"])
 
       page.visit @managed_group_url
       Support::Waiter.wait { current_url == @managed_group_url }

qa/qa/vendor/saml_idp/page/login.rb

@@ -8,7 +8,7 @@ module QA
       module Page
         class Login < Page::Base
           def login(username, password)
-            QA::Runtime::Logger.debug("Logging into SAMLIdp with username: #{username} and password:#{password}") if QA::Runtime::Env.debug?
+            QA::Runtime::Logger.debug("Logging into SAMLIdp with username: #{username} and password:#{password}")
 
             fill_in 'username', with: username
             fill_in 'password', with: password
@@ -21,7 +21,7 @@ module QA
 
           def login_required?
             login_required = page.has_text?('Enter your username and password')
-            QA::Runtime::Logger.debug("login_required: #{login_required}") if QA::Runtime::Env.debug?
+            QA::Runtime::Logger.debug("login_required: #{login_required}")
             login_required
           end
         end

qa/spec/spec_helper.rb

@@ -20,7 +20,7 @@ RSpec.configure do |config|
   QA::Specs::Helpers::Quarantine.configure_rspec
 
   config.before do |example|
-    QA::Runtime::Logger.debug("\nStarting test: #{example.full_description}\n") if QA::Runtime::Env.debug?
+    QA::Runtime::Logger.debug("\nStarting test: #{example.full_description}\n")
   end
 
   config.after(:context) do