Refactor replicable package files scope

to improve performance and readability.

ee/app/models/ee/packages/package_file.rb

@@ -29,20 +29,8 @@ module EE
         def selective_sync_scope
           return self.all unless ::Gitlab::Geo.current_node.selective_sync?
 
-          query = ::Packages::Package.where(project_id: ::Gitlab::Geo.current_node.projects).select(:id)
-          cte = ::Gitlab::SQL::CTE.new(:restricted_packages, query)
-          replicable_table = self.arel_table
-
-          inner_join_restricted_packages =
-            cte.table
-              .join(replicable_table, Arel::Nodes::InnerJoin)
-              .on(cte.table[:id].eq(replicable_table[:package_id]))
-              .join_sources
-
-          self
-            .with(cte.to_arel)
-            .from(cte.table)
-            .joins(inner_join_restricted_packages)
+          self.joins(:package)
+              .where('packages_packages.project_id IN (?)', ::Gitlab::Geo.current_node.projects.select(:id))
         end
       end
 

ee/changelogs/unreleased/mk-refactor-replicable-package-files-scope.yml

+---
+title: 'Geo: Improve performance of package files queries'
+merge_request: 42294
+author:
+type: performance