Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ccc5ba05
Commit
ccc5ba05
authored
Aug 12, 2020
by
David O'Regan
Committed by
Andrew Fontaine
Aug 12, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replace mis-used CSS class
parent
973c6177
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
16 additions
and
11 deletions
+16
-11
app/assets/javascripts/incidents_settings/components/incidents_settings_tabs.vue
...incidents_settings/components/incidents_settings_tabs.vue
+2
-2
changelogs/unreleased/227838-h3-h4-class-fix.yml
changelogs/unreleased/227838-h3-h4-class-fix.yml
+5
-0
ee/app/assets/javascripts/status_page_settings/components/settings_form.vue
...scripts/status_page_settings/components/settings_form.vue
+2
-2
ee/spec/frontend/status_page_settings/__snapshots__/settings_form_spec.js.snap
...us_page_settings/__snapshots__/settings_form_spec.js.snap
+3
-3
spec/features/projects/settings/operations_settings_spec.rb
spec/features/projects/settings/operations_settings_spec.rb
+1
-1
spec/frontend/incidents_settings/components/__snapshots__/incidents_settings_tabs_spec.js.snap
...onents/__snapshots__/incidents_settings_tabs_spec.js.snap
+3
-3
No files found.
app/assets/javascripts/incidents_settings/components/incidents_settings_tabs.vue
View file @
ccc5ba05
...
@@ -24,9 +24,9 @@ export default {
...
@@ -24,9 +24,9 @@ export default {
class=
"settings no-animate qa-incident-management-settings"
class=
"settings no-animate qa-incident-management-settings"
>
>
<div
class=
"settings-header"
>
<div
class=
"settings-header"
>
<h
3
ref=
"sectionHeader"
class=
"h4
"
>
<h
4
ref=
"sectionHeader"
class=
"gl-my-3! gl-py-1
"
>
{{
$options
.
i18n
.
headerText
}}
{{
$options
.
i18n
.
headerText
}}
</h
3
>
</h
4
>
<gl-button
ref=
"toggleBtn"
class=
"js-settings-toggle"
>
{{
<gl-button
ref=
"toggleBtn"
class=
"js-settings-toggle"
>
{{
$options
.
i18n
.
expandBtnLabel
$options
.
i18n
.
expandBtnLabel
}}
</gl-button>
}}
</gl-button>
...
...
changelogs/unreleased/227838-h3-h4-class-fix.yml
0 → 100644
View file @
ccc5ba05
---
title
:
Replace mis-used CSS class in operations settings
merge_request
:
39338
author
:
type
:
changed
ee/app/assets/javascripts/status_page_settings/components/settings_form.vue
View file @
ccc5ba05
...
@@ -75,9 +75,9 @@ export default {
...
@@ -75,9 +75,9 @@ export default {
<
template
>
<
template
>
<section
id=
"status-page"
class=
"settings no-animate js-status-page-settings"
>
<section
id=
"status-page"
class=
"settings no-animate js-status-page-settings"
>
<div
class=
"settings-header"
>
<div
class=
"settings-header"
>
<h
3
ref=
"sectionHeader"
class=
"h4
"
>
<h
4
ref=
"sectionHeader"
class=
"gl-my-3! gl-py-1
"
>
{{
$options
.
i18n
.
headerText
}}
{{
$options
.
i18n
.
headerText
}}
</h
3
>
</h
4
>
<gl-button
ref=
"toggleBtn"
class=
"js-settings-toggle"
>
{{
<gl-button
ref=
"toggleBtn"
class=
"js-settings-toggle"
>
{{
$options
.
i18n
.
expandBtnLabel
$options
.
i18n
.
expandBtnLabel
}}
</gl-button>
}}
</gl-button>
...
...
ee/spec/frontend/status_page_settings/__snapshots__/settings_form_spec.js.snap
View file @
ccc5ba05
...
@@ -8,13 +8,13 @@ exports[`Status Page settings form default state should match the default snapsh
...
@@ -8,13 +8,13 @@ exports[`Status Page settings form default state should match the default snapsh
<div
<div
class="settings-header"
class="settings-header"
>
>
<h
3
<h
4
class="
h4
"
class="
gl-my-3! gl-py-1
"
>
>
Status page
Status page
</h
3
>
</h
4
>
<gl-button-stub
<gl-button-stub
class="js-settings-toggle"
class="js-settings-toggle"
...
...
spec/features/projects/settings/operations_settings_spec.rb
View file @
ccc5ba05
...
@@ -35,7 +35,7 @@ RSpec.describe 'Projects > Settings > For a forked project', :js do
...
@@ -35,7 +35,7 @@ RSpec.describe 'Projects > Settings > For a forked project', :js do
end
end
it
'renders form for incident management'
do
it
'renders form for incident management'
do
expect
(
page
).
to
have_selector
(
'h
3
'
,
text:
'Incidents'
)
expect
(
page
).
to
have_selector
(
'h
4
'
,
text:
'Incidents'
)
end
end
it
'sets correct default values'
do
it
'sets correct default values'
do
...
...
spec/frontend/incidents_settings/components/__snapshots__/incidents_settings_tabs_spec.js.snap
View file @
ccc5ba05
...
@@ -9,13 +9,13 @@ exports[`IncidentsSettingTabs should render the component 1`] = `
...
@@ -9,13 +9,13 @@ exports[`IncidentsSettingTabs should render the component 1`] = `
<div
<div
class="settings-header"
class="settings-header"
>
>
<h
3
<h
4
class="
h4
"
class="
gl-my-3! gl-py-1
"
>
>
Incidents
Incidents
</h
3
>
</h
4
>
<gl-button-stub
<gl-button-stub
category="tertiary"
category="tertiary"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment