Commit cd205130 authored by Scott Hampton's avatar Scott Hampton

Fix test history badge alignment

Put the badge back inside the button. If it's not
there, then the gl-badge stretches to fill the
space if the issue name takes up multiple lines.
I could instead use `gl-display-items-flex-start`
but that caused the issue name to be aligned to
the top of the badge instead of the text in the
badge.
parent 927cbd61
...@@ -24,7 +24,7 @@ export default { ...@@ -24,7 +24,7 @@ export default {
n__( n__(
'Reports|Failed %{count} time in %{base_branch} in the last 14 days', 'Reports|Failed %{count} time in %{base_branch} in the last 14 days',
'Reports|Failed %{count} times in %{base_branch} in the last 14 days', 'Reports|Failed %{count} times in %{base_branch} in the last 14 days',
this.issue.recent_failures.count, this.issue.recent_failures?.count,
), ),
this.issue.recent_failures, this.issue.recent_failures,
); );
...@@ -44,20 +44,20 @@ export default { ...@@ -44,20 +44,20 @@ export default {
<template> <template>
<div class="gl-display-flex gl-mt-2 gl-mb-2"> <div class="gl-display-flex gl-mt-2 gl-mb-2">
<issue-status-icon :status="status" :status-icon-size="24" class="gl-mr-3" /> <issue-status-icon :status="status" :status-icon-size="24" class="gl-mr-3" />
<gl-badge
v-if="showRecentFailures"
variant="warning"
class="gl-mr-2"
data-testid="test-issue-body-recent-failures"
>
{{ recentFailureMessage }}
</gl-badge>
<gl-button <gl-button
button-text-classes="gl-white-space-normal! gl-word-break-all gl-text-left" button-text-classes="gl-white-space-normal! gl-word-break-all gl-text-left"
variant="link" variant="link"
data-testid="test-issue-body-description" data-testid="test-issue-body-description"
@click="openModal({ issue })" @click="openModal({ issue })"
> >
<gl-badge
v-if="showRecentFailures"
variant="warning"
class="gl-mr-2"
data-testid="test-issue-body-recent-failures"
>
{{ recentFailureMessage }}
</gl-badge>
{{ issue.name }} {{ issue.name }}
</gl-button> </gl-button>
</div> </div>
......
...@@ -52,7 +52,7 @@ describe('Test issue body', () => { ...@@ -52,7 +52,7 @@ describe('Test issue body', () => {
}); });
it('renders issue name', () => { it('renders issue name', () => {
expect(findDescription().text()).toBe(failedIssue.name); expect(findDescription().text()).toContain(failedIssue.name);
}); });
it('renders failed status icon', () => { it('renders failed status icon', () => {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment