Remove implicit FF check on `Featurable`

This ensures that we do not perform implicit
check for features that should not be treated
as feature-flagged.

The feature flag in such cases should be
explicitly defined.

app/models/concerns/featurable.rb

@@ -88,9 +88,6 @@ module Featurable
   end
 
   def feature_available?(feature, user)
-    # This feature might not be behind a feature flag at all, so default to true
-    return false unless ::Feature.enabled?(feature, user, default_enabled: true)
-
     get_permission(user, feature)
   end
 

changelogs/unreleased/remove-implicit-feature-flag-check-on-featurable.yml

+---
+title: Remove implicit FF check on `Featurable`
+merge_request:
+author:
+type: removed

spec/models/concerns/featurable_spec.rb

@@ -134,22 +134,6 @@ RSpec.describe Featurable do
         expect(project.feature_available?(:issues, user)).to eq(true)
       end
     end
-
-    context 'when feature is disabled by a feature flag' do
-      it 'returns false' do
-        stub_feature_flags(issues: false)
-
-        expect(project.feature_available?(:issues, user)).to eq(false)
-      end
-    end
-
-    context 'when feature is enabled by a feature flag' do
-      it 'returns true' do
-        stub_feature_flags(issues: true)
-
-        expect(project.feature_available?(:issues, user)).to eq(true)
-      end
-    end
   end
 
   describe '#*_enabled?' do