Commit ce5508ad authored by Dave Pisek's avatar Dave Pisek

Reviewer feedback: Injection defaults, gl-class

* Adds defaults to injected values
* Uses a `gl-` class for green text color
* Switches div to ul
parent 51eb87ee
......@@ -45,11 +45,11 @@ export default {
<template #title>
{{ popoverTitle }}
</template>
<div>
<div v-for="{ issue } in issues" :key="issue.iid">
<ul class="gl-list-style-none gl-p-0 gl-m-0">
<li v-for="{ issue } in issues" :key="issue.iid">
<issue-link :issue="issue" :is-jira="isJira" />
</div>
</div>
</li>
</ul>
</gl-popover>
</div>
</template>
......@@ -16,7 +16,14 @@ export default {
GlIntersectionObserver,
VulnerabilityList,
},
inject: ['projectFullPath', 'hasJiraVulnerabilitiesIntegrationEnabled'],
inject: {
projectFullPath: {
default: '',
},
hasJiraVulnerabilitiesIntegrationEnabled: {
default: false,
},
},
props: {
filters: {
type: Object,
......
......@@ -52,7 +52,15 @@ export default {
directives: {
GlTooltip: GlTooltipDirective,
},
inject: ['hasVulnerabilities', 'hasJiraVulnerabilitiesIntegrationEnabled'],
inject: {
hasVulnerabilities: {
default: false,
},
hasJiraVulnerabilitiesIntegrationEnabled: {
default: false,
},
},
props: {
filters: {
type: Object,
......
......@@ -37,15 +37,18 @@ export default {
target="__blank"
class="gl-display-inline-flex gl-align-items-center gl-flex-shrink-0"
>
<span class="gl-mr-3">
<span
v-if="isJira"
v-safe-html="$options.jiraLogo"
class="gl-min-h-6 gl-display-inline-flex gl-align-items-center"
data-testid="jira-logo"
></span>
<gl-icon v-else :class="{ cgreen: issue.state === $options.STATE_OPENED }" :name="iconName" />
</span>
<span
v-if="isJira"
v-safe-html="$options.jiraLogo"
class="gl-min-h-6 gl-mr-3 gl-display-inline-flex gl-align-items-center"
data-testid="jira-logo"
></span>
<gl-icon
v-else
class="gl-mr-1"
:class="{ 'gl-text-green-600': issue.state === $options.STATE_OPENED }"
:name="iconName"
/>
#{{ issue.iid }}
<gl-icon v-if="isJira" :size="12" name="external-link" class="gl-ml-1" />
</gl-link>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment