Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ce68c060
Commit
ce68c060
authored
Jul 22, 2020
by
Maxime Orefice
Committed by
Andrew Fontaine
Jul 22, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Track codequality report click
parent
38640295
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
1 deletion
+6
-1
ee/app/views/projects/pipelines/_tabs_holder.html.haml
ee/app/views/projects/pipelines/_tabs_holder.html.haml
+1
-1
ee/spec/features/projects/pipelines/pipeline_spec.rb
ee/spec/features/projects/pipelines/pipeline_spec.rb
+5
-0
No files found.
ee/app/views/projects/pipelines/_tabs_holder.html.haml
View file @
ce68c060
...
...
@@ -14,5 +14,5 @@
-
if
pipeline
.
downloadable_path_for_report_type
(
:codequality
)
%li
.js-codequality-tab-link
=
link_to
codequality_report_project_pipeline_path
(
project
,
pipeline
),
data:
{
target:
'#js-tab-codequality'
,
action:
'codequality_report'
,
toggle:
'tab'
},
class:
'codequality-tab'
do
=
link_to
codequality_report_project_pipeline_path
(
project
,
pipeline
),
data:
{
target:
'#js-tab-codequality'
,
action:
'codequality_report'
,
toggle:
'tab'
,
'track-event'
:
'click_button'
,
'track-label'
:
'get_codequality_report'
},
class:
'codequality-tab'
do
=
_
(
'Code Quality'
)
ee/spec/features/projects/pipelines/pipeline_spec.rb
View file @
ce68c060
...
...
@@ -200,6 +200,11 @@ RSpec.describe 'Pipeline', :js do
expect
(
page
).
to
have_content
(
'Function `simulateEvent` has 28 lines of code (exceeds 25 allowed). Consider refactoring.'
)
expect
(
find_link
(
'app/assets/javascripts/test_utils/simulate_drag.js:1'
)[
:href
]).
to
end_with
(
project_blob_path
(
project
,
File
.
join
(
pipeline
.
commit
.
id
,
'app/assets/javascripts/test_utils/simulate_drag.js'
))
+
'#L1'
)
end
it
'contains events for data tracking'
,
:aggregate_failures
do
expect
(
page
).
to
have_selector
(
'[data-track-event="click_button"]'
)
expect
(
page
).
to
have_selector
(
'[data-track-label="get_codequality_report"]'
)
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment