Merge branch 'organize-shared-examples' into 'master'

Organize the shared context and examples

See merge request gitlab-org/gitlab!23323

spec/lib/gitlab/email/receiver_spec.rb

@@ -5,6 +5,14 @@ require 'spec_helper'
 describe Gitlab::Email::Receiver do
   include_context :email_shared_context
 
+  shared_examples 'correctly finds the mail key' do
+    specify do
+      expect(Gitlab::Email::Handler).to receive(:for).with(an_instance_of(Mail::Message), 'gitlabhq/gitlabhq+auth_token').and_return(handler)
+
+      receiver.execute
+    end
+  end
+
   context 'when the email contains a valid email address in a header' do
     let(:handler) { double(:handler) }
 

spec/lib/gitlab/mail_room/mail_room_spec.rb

@@ -16,6 +16,40 @@ describe Gitlab::MailRoom do
     }
   end
 
+  shared_examples_for 'only truthy if both enabled and address are truthy' do |target_proc|
+    context 'with both enabled and address as truthy values' do
+      it 'is truthy' do
+        stub_config(enabled: true, address: 'localhost')
+
+        expect(target_proc.call).to be_truthy
+      end
+    end
+
+    context 'with address only as truthy' do
+      it 'is falsey' do
+        stub_config(enabled: false, address: 'localhost')
+
+        expect(target_proc.call).to be_falsey
+      end
+    end
+
+    context 'with enabled only as truthy' do
+      it 'is falsey' do
+        stub_config(enabled: true, address: nil)
+
+        expect(target_proc.call).to be_falsey
+      end
+    end
+
+    context 'with neither address nor enabled as truthy' do
+      it 'is falsey' do
+        stub_config(enabled: false, address: nil)
+
+        expect(target_proc.call).to be_falsey
+      end
+    end
+  end
+
   before do
     described_class.reset_config!
     allow(File).to receive(:exist?).and_return true

spec/lib/gitlab/untrusted_regexp/ruby_syntax_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
-require 'support/shared_examples/malicious_regexp_shared_examples'
+require 'support/shared_examples/lib/gitlab/malicious_regexp_shared_examples'
 require 'support/helpers/stub_feature_flags'
 
 describe Gitlab::UntrustedRegexp::RubySyntax do

spec/lib/gitlab/untrusted_regexp_spec.rb

 # frozen_string_literal: true
 
 require 'fast_spec_helper'
-require 'support/shared_examples/malicious_regexp_shared_examples'
+require 'support/shared_examples/lib/gitlab/malicious_regexp_shared_examples'
 
 describe Gitlab::UntrustedRegexp do
   describe '#initialize' do

spec/models/ci/build_trace_chunk_spec.rb

@@ -27,7 +27,42 @@ describe Ci::BuildTraceChunk, :clean_gitlab_redis_shared_state do
     let(:build) { create(:ci_build, :running, :trace_live, pipeline: pipeline, project: parent) }
     let(:subjects) { build.trace_chunks }
 
-    it_behaves_like 'fast destroyable'
+    describe 'Forbid #destroy and #destroy_all' do
+      it 'does not delete database rows and associted external data' do
+        expect(external_data_counter).to be > 0
+        expect(subjects.count).to be > 0
+
+        expect { subjects.first.destroy }.to raise_error('`destroy` and `destroy_all` are forbidden. Please use `fast_destroy_all`')
+        expect { subjects.destroy_all }.to raise_error('`destroy` and `destroy_all` are forbidden. Please use `fast_destroy_all`') # rubocop: disable DestroyAll
+
+        expect(subjects.count).to be > 0
+        expect(external_data_counter).to be > 0
+      end
+    end
+
+    describe '.fast_destroy_all' do
+      it 'deletes database rows and associted external data' do
+        expect(external_data_counter).to be > 0
+        expect(subjects.count).to be > 0
+
+        expect { subjects.fast_destroy_all }.not_to raise_error
+
+        expect(subjects.count).to eq(0)
+        expect(external_data_counter).to eq(0)
+      end
+    end
+
+    describe '.use_fast_destroy' do
+      it 'performs cascading delete with fast_destroy_all' do
+        expect(external_data_counter).to be > 0
+        expect(subjects.count).to be > 0
+
+        expect { parent.destroy }.not_to raise_error
+
+        expect(subjects.count).to eq(0)
+        expect(external_data_counter).to eq(0)
+      end
+    end
 
     def external_data_counter
       Gitlab::Redis::SharedState.with do |redis|

spec/services/projects/update_pages_service_spec.rb

@@ -176,6 +176,35 @@ describe Projects::UpdatePagesService do
   describe 'maximum pages artifacts size' do
     let(:metadata) { spy('metadata') }
 
+    shared_examples 'pages size limit is' do |size_limit|
+      context "when size is below the limit" do
+        before do
+          allow(metadata).to receive(:total_size).and_return(size_limit - 1.megabyte)
+        end
+
+        it 'updates pages correctly' do
+          subject.execute
+
+          expect(deploy_status.description).not_to be_present
+          expect(project.pages_metadatum).to be_deployed
+        end
+      end
+
+      context "when size is above the limit" do
+        before do
+          allow(metadata).to receive(:total_size).and_return(size_limit + 1.megabyte)
+        end
+
+        it 'limits the maximum size of gitlab pages' do
+          subject.execute
+
+          expect(deploy_status.description)
+            .to match(/artifacts for pages are too large/)
+          expect(deploy_status).to be_script_failure
+        end
+      end
+    end
+
     before do
       file = fixture_file_upload('spec/fixtures/pages.zip')
       metafile = fixture_file_upload('spec/fixtures/pages.zip.meta')

spec/support/banzai/reference_filter_shared_examples.rb

@@ -4,7 +4,7 @@
 #
 # Requires a reference:
 #   let(:reference) { '#42' }
-shared_examples 'a reference containing an element node' do
+RSpec.shared_examples 'a reference containing an element node' do
   let(:inner_html) { 'element <code>node</code> inside' }
   let(:reference_with_element) { %{<a href="#{reference}">#{inner_html}</a>} }
 
@@ -18,7 +18,7 @@ end
 #   subject { create(:user) }
 #   let(:reference) { subject.to_reference }
 #   let(:subject_name) { 'user' }
-shared_examples 'user reference or project reference' do
+RSpec.shared_examples 'user reference or project reference' do
   shared_examples 'it contains a data- attribute' do
     it 'includes a data- attribute' do
       doc = reference_filter("Hey #{reference}")

spec/support/services/clusters/create_service_shared.rb

 # frozen_string_literal: true
 
-shared_context 'valid cluster create params' do
+RSpec.shared_context 'valid cluster create params' do
   let(:params) do
     {
       name: 'test-cluster',
@@ -16,7 +16,7 @@ shared_context 'valid cluster create params' do
   end
 end
 
-shared_context 'invalid cluster create params' do
+RSpec.shared_context 'invalid cluster create params' do
   let(:params) do
     {
       name: 'test-cluster',
@@ -31,7 +31,7 @@ shared_context 'invalid cluster create params' do
   end
 end
 
-shared_examples 'create cluster service success' do
+RSpec.shared_examples 'create cluster service success' do
   it 'creates a cluster object and performs a worker' do
     expect(ClusterProvisionWorker).to receive(:perform_async)
 
@@ -53,7 +53,7 @@ shared_examples 'create cluster service success' do
   end
 end
 
-shared_examples 'create cluster service error' do
+RSpec.shared_examples 'create cluster service error' do
   it 'returns an error' do
     expect(ClusterProvisionWorker).not_to receive(:perform_async)
     expect { subject }.to change { Clusters::Cluster.count }.by(0)

spec/support/services/issuable_create_service_slash_commands_shared_examples.rb

@@ -3,7 +3,7 @@
 # Specifications for behavior common to all objects with executable attributes.
 # It can take a `default_params`.
 
-shared_examples 'new issuable record that supports quick actions' do
+RSpec.shared_examples 'new issuable record that supports quick actions' do
   let!(:project) { create(:project, :repository) }
   let(:user) { create(:user).tap { |u| project.add_maintainer(u) } }
   let(:assignee) { create(:user) }

spec/support/services/issuable_update_service_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'issuable update service' do
+RSpec.shared_examples 'issuable update service' do
   def update_issuable(opts)
     described_class.new(project, user, opts).execute(open_issuable)
   end

spec/support/services/migrate_to_ghost_user_service_shared_examples.rb

 # frozen_string_literal: true
 
-require "spec_helper"
-
-shared_examples "migrating a deleted user's associated records to the ghost user" do |record_class, fields|
+RSpec.shared_examples "migrating a deleted user's associated records to the ghost user" do |record_class, fields|
   record_class_name = record_class.to_s.titleize.downcase
 
   let(:project) do

spec/support/shared_contexts/change_access_checks_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'change access checks context' do
+RSpec.shared_context 'change access checks context' do
   let(:user) { create(:user) }
   let(:project) { create(:project, :repository) }
   let(:user_access) { Gitlab::UserAccess.new(user, project: project) }

spec/support/controllers/githubish_import_controller_shared_context.rb → spec/support/shared_contexts/controllers/githubish_import_controller_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'a GitHub-ish import controller' do
+RSpec.shared_context 'a GitHub-ish import controller' do
   let(:user) { create(:user) }
   let(:token) { "asdasd12345" }
   let(:access_params) { { github_access_token: token } }

spec/support/controllers/ldap_omniauth_callbacks_controller_shared_context.rb → spec/support/shared_contexts/controllers/ldap_omniauth_callbacks_controller_shared_context.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
-shared_context 'Ldap::OmniauthCallbacksController' do
+RSpec.shared_context 'Ldap::OmniauthCallbacksController' do
   include LoginHelpers
   include LdapHelpers
 

spec/support/shared_contexts/email_shared_context.rb

 # frozen_string_literal: true
 
-shared_context :email_shared_context do
+RSpec.shared_context :email_shared_context do
   let(:mail_key) { "59d8df8370b7e95c5a49fbf86aeb2c93" }
   let(:receiver) { Gitlab::Email::Receiver.new(email_raw) }
   let(:markdown) { "![image](uploads/image.png)" }
@@ -18,7 +18,7 @@ shared_context :email_shared_context do
   end
 end
 
-shared_examples :reply_processing_shared_examples do
+RSpec.shared_examples :reply_processing_shared_examples do
   context "when the user could not be found" do
     before do
       user.destroy

spec/support/shared_contexts/finders/group_projects_finder_shared_contexts.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.shared_context 'GroupProjectsFinder context' do
   let(:group) { create(:group) }
   let(:subgroup) { create(:group, parent: group) }

spec/support/shared_contexts/finders/issues_finder_shared_contexts.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.shared_context 'IssuesFinder context' do
   set(:user) { create(:user) }
   set(:user2) { create(:user) }

spec/support/shared_contexts/finders/merge_requests_finder_shared_contexts.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.shared_context 'MergeRequestsFinder multiple projects with merge requests context' do
   include ProjectForksHelper
 

spec/support/shared_contexts/finders/users_finder_shared_contexts.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
 RSpec.shared_context 'UsersFinder#execute filter by project context' do
   set(:normal_user) { create(:user, username: 'johndoe') }
   set(:blocked_user) { create(:user, :blocked, username: 'notsorandom') }

spec/support/shared_contexts/json_response_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'JSON response' do
+RSpec.shared_context 'JSON response' do
   let(:json_response) { JSON.parse(response.body) }
 end

spec/support/shared_contexts/mailers/notify_shared_context.rb

+# frozen_string_literal: true
+
+RSpec.shared_context 'gitlab email notification' do
+  set(:group) { create(:group) }
+  set(:subgroup) { create(:group, parent: group) }
+  set(:project) { create(:project, :repository, name: 'a-known-name', group: group) }
+  set(:recipient) { create(:user, email: 'recipient@example.com') }
+
+  let(:gitlab_sender_display_name) { Gitlab.config.gitlab.email_display_name }
+  let(:gitlab_sender) { Gitlab.config.gitlab.email_from }
+  let(:gitlab_sender_reply_to) { Gitlab.config.gitlab.email_reply_to }
+  let(:new_user_address) { 'newguy@example.com' }
+
+  before do
+    email = recipient.emails.create(email: "notifications@example.com")
+    recipient.update_attribute(:notification_email, email.email)
+    stub_incoming_email_setting(enabled: true, address: "reply+%{key}@#{Gitlab.config.gitlab.host}")
+  end
+end
+
+RSpec.shared_context 'reply-by-email is enabled with incoming address without %{key}' do
+  before do
+    stub_incoming_email_setting(enabled: true, address: "reply@#{Gitlab.config.gitlab.host}")
+  end
+end

spec/support/shared_contexts/merge_request_create.rb → spec/support/shared_contexts/merge_request_create_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'merge request create context' do
+RSpec.shared_context 'merge request create context' do
   let(:user)        { create(:user) }
   let(:user2)       { create(:user) }
   let(:target_project) { create(:project, :public, :repository) }

spec/support/shared_contexts/merge_request_edit.rb → spec/support/shared_contexts/merge_request_edit_shared_context.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-shared_context 'merge request edit context' do
+RSpec.shared_context 'merge request edit context' do
   let(:user)        { create(:user) }
   let(:user2)       { create(:user) }
   let!(:milestone)   { create(:milestone, project: target_project) }

spec/support/shared_contexts/merge_requests_allowing_collaboration.rb → spec/support/shared_contexts/merge_requests_allowing_collaboration_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'merge request allowing collaboration' do
+RSpec.shared_context 'merge request allowing collaboration' do
   include ProjectForksHelper
 
   let(:canonical) { create(:project, :public, :repository) }

spec/support/shared_contexts/rack_attack_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'rack attack cache store' do
+RSpec.shared_context 'rack attack cache store' do
   around do |example|
     # Instead of test environment's :null_store so the throttles can increment
     Rack::Attack.cache.store = ActiveSupport::Cache::MemoryStore.new

spec/support/shared_contexts/services_shared_context.rb

 # frozen_string_literal: true
 
 Service.available_services_names.each do |service|
-  shared_context service do
+  RSpec.shared_context service do
     let(:dashed_service) { service.dasherize }
     let(:service_method) { "#{service}_service".to_sym }
     let(:service_klass) { "#{service}_service".classify.constantize }

spec/support/shared_contexts/session_shared_context.rb

@@ -4,7 +4,7 @@
 # let(:session) variable
 # we do not use a parameter such as |session| because it does not play nice
 # with let variables
-shared_context 'custom session' do
+RSpec.shared_context 'custom session' do
   let!(:session) { {} }
 
   around do |example|

spec/support/shared_contexts/unique_ip_check_shared_context.rb

+# frozen_string_literal: true
+
+RSpec.shared_context 'unique ips sign in limit' do
+  include StubENV
+  let(:request_context) { Gitlab::RequestContext.instance }
+
+  before do
+    Gitlab::Redis::Cache.with(&:flushall)
+    Gitlab::Redis::Queues.with(&:flushall)
+    Gitlab::Redis::SharedState.with(&:flushall)
+  end
+
+  before do
+    stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
+
+    Gitlab::CurrentSettings.update!(
+      unique_ips_limit_enabled: true,
+      unique_ips_limit_time_window: 10000
+    )
+
+    # Make sure we're working with the same reqeust context everywhere
+    allow(Gitlab::RequestContext).to receive(:instance).and_return(request_context)
+  end
+
+  def change_ip(ip)
+    allow(request_context).to receive(:client_ip).and_return(ip)
+  end
+
+  def request_from_ip(ip)
+    change_ip(ip)
+    request
+    response
+  end
+
+  def operation_from_ip(ip)
+    change_ip(ip)
+    operation
+  end
+end

spec/support/shared_contexts/upload_type_check_shared_context.rb

@@ -2,7 +2,7 @@
 
 # Construct an `uploader` variable that is configured to `check_upload_type`
 # with `mime_types` and `extensions`.
-shared_context 'uploader with type check' do
+RSpec.shared_context 'uploader with type check' do
   let(:uploader_class) do
     Class.new(GitlabUploader) do
       include UploadTypeCheck::Concern
@@ -20,7 +20,7 @@ shared_context 'uploader with type check' do
   end
 end
 
-shared_context 'stubbed MimeMagic mime type detection' do
+RSpec.shared_context 'stubbed MimeMagic mime type detection' do
   let(:mime_type) { '' }
   let(:magic_mime) { mime_type }
   let(:ext_mime) { mime_type }

spec/support/shared_contexts/url_shared_context.rb

 # frozen_string_literal: true
 
-shared_context 'invalid urls' do
+RSpec.shared_context 'invalid urls' do
   let(:urls_with_CRLF) do
     ["http://127.0.0.1:333/pa\rth",
      "http://127.0.0.1:333/pa\nth",

spec/support/shared_examples/boards/multiple_issue_boards_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples_for 'multiple issue boards' do
+RSpec.shared_examples 'multiple issue boards' do
   context 'authorized user' do
     before do
       parent.add_maintainer(user)

spec/support/shared_examples/ci/auto_merge_merge_requests_examples.rb → spec/support/shared_examples/ci/auto_merge_merge_requests_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'aborted merge requests for MWPS' do
+RSpec.shared_examples 'aborted merge requests for MWPS' do
   let(:aborted_message) do
     /aborted the automatic merge because target branch was updated/
   end
@@ -23,7 +23,7 @@ shared_examples 'aborted merge requests for MWPS' do
   end
 end
 
-shared_examples 'maintained merge requests for MWPS' do
+RSpec.shared_examples 'maintained merge requests for MWPS' do
   it 'does not cancel auto merge' do
     expect(merge_request.auto_merge_enabled?).to be_truthy
     expect(merge_request.notes).to be_empty

spec/support/shared_examples/ci/pipeline_email_examples.rb → spec/support/shared_examples/ci/pipeline_email_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples_for 'correct pipeline information for pipelines for merge requests' do
+RSpec.shared_examples 'correct pipeline information for pipelines for merge requests' do
   context 'when pipeline for merge request' do
     let(:pipeline) { merge_request.all_pipelines.first }
 

spec/support/shared_examples/ci/stage_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'manual playable stage' do |stage_type|
+RSpec.shared_examples 'manual playable stage' do |stage_type|
   let(:stage) { build(stage_type, status: status) }
 
   describe '#manual_playable?' do

spec/support/shared_examples/controllers/application_settings_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'renders correct panels' do
+RSpec.shared_examples 'renders correct panels' do
   it 'renders correct action on error' do
     expect_next_instance_of(ApplicationSettings::UpdateService) do |service|
       allow(service).to receive(:execute).and_return(false)

spec/support/shared_examples/discussions_provider_shared_examples.rb → spec/support/shared_examples/controllers/discussions_provider_shared_examples.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
-shared_examples 'discussions provider' do
+RSpec.shared_examples 'discussions provider' do
   it 'returns the expected discussions' do
     get :discussions, params: { namespace_id: project.namespace, project_id: project, id: requested_iid }
 

spec/support/shared_examples/controllers/environments_controller_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples_for 'successful response for #cancel_auto_stop' do
+RSpec.shared_examples 'successful response for #cancel_auto_stop' do
   include GitlabRoutingHelper
 
   context 'when request is html' do
@@ -42,7 +42,7 @@ shared_examples_for 'successful response for #cancel_auto_stop' do
   end
 end
 
-shared_examples_for 'failed response for #cancel_auto_stop' do
+RSpec.shared_examples 'failed response for #cancel_auto_stop' do
   context 'when request is html' do
     let(:params) { environment_params(format: :html) }
 

spec/support/shared_examples/controllers/error_tracking_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'sets the polling header' do
+RSpec.shared_examples 'sets the polling header' do
   subject { response.headers[Gitlab::PollingInterval::HEADER_NAME] }
 
   it { is_expected.to eq '1000'}

spec/support/shared_examples/controllers/external_authorization_service_shared_examples.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
-shared_examples 'disabled when using an external authorization service' do
+RSpec.shared_examples 'disabled when using an external authorization service' do
   include ExternalAuthorizationServiceHelpers
 
   it 'works when the feature is not enabled' do
@@ -20,7 +18,7 @@ shared_examples 'disabled when using an external authorization service' do
   end
 end
 
-shared_examples 'unauthorized when external service denies access' do
+RSpec.shared_examples 'unauthorized when external service denies access' do
   include ExternalAuthorizationServiceHelpers
 
   it 'allows access when the authorization service allows it' do

spec/support/controllers/githubish_import_controller_shared_examples.rb → spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb

@@ -10,7 +10,7 @@ def assign_session_token(provider)
   session[:"#{provider}_access_token"] = 'asdasd12345'
 end
 
-shared_examples 'a GitHub-ish import controller: POST personal_access_token' do
+RSpec.shared_examples 'a GitHub-ish import controller: POST personal_access_token' do
   let(:status_import_url) { public_send("status_import_#{provider}_url") }
 
   it "updates access token" do
@@ -38,7 +38,7 @@ shared_examples 'a GitHub-ish import controller: POST personal_access_token' do
   end
 end
 
-shared_examples 'a GitHub-ish import controller: GET new' do
+RSpec.shared_examples 'a GitHub-ish import controller: GET new' do
   let(:status_import_url) { public_send("status_import_#{provider}_url") }
 
   it "redirects to status if we already have a token" do
@@ -57,7 +57,7 @@ shared_examples 'a GitHub-ish import controller: GET new' do
   end
 end
 
-shared_examples 'a GitHub-ish import controller: GET status' do
+RSpec.shared_examples 'a GitHub-ish import controller: GET status' do
   let(:new_import_url) { public_send("new_import_#{provider}_url") }
   let(:user) { create(:user) }
   let(:repo) { OpenStruct.new(login: 'vim', full_name: 'asd/vim', name: 'vim', owner: { login: 'owner' }) }
@@ -76,7 +76,7 @@ shared_examples 'a GitHub-ish import controller: GET status' do
 
     get :status, format: :json
 
-    expect(response).to have_gitlab_http_status(200)
+    expect(response).to have_gitlab_http_status(:ok)
     expect(json_response.dig("imported_projects", 0, "id")).to eq(project.id)
     expect(json_response.dig("provider_repos", 0, "id")).to eq(repo.id)
     expect(json_response.dig("provider_repos", 1, "id")).to eq(org_repo.id)
@@ -107,7 +107,7 @@ shared_examples 'a GitHub-ish import controller: GET status' do
 
     get :status
 
-    expect(response).to have_gitlab_http_status(200)
+    expect(response).to have_gitlab_http_status(:ok)
   end
 
   it "handles an invalid access token" do
@@ -153,7 +153,7 @@ shared_examples 'a GitHub-ish import controller: GET status' do
     it 'filters list of repositories by name' do
       get :status, params: { filter: 'emacs' }, format: :json
 
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
       expect(json_response.dig("imported_projects").count).to eq(0)
       expect(json_response.dig("provider_repos").count).to eq(1)
       expect(json_response.dig("provider_repos", 0, "id")).to eq(repo_2.id)
@@ -173,7 +173,7 @@ shared_examples 'a GitHub-ish import controller: GET status' do
   end
 end
 
-shared_examples 'a GitHub-ish import controller: POST create' do
+RSpec.shared_examples 'a GitHub-ish import controller: POST create' do
   let(:user) { create(:user) }
   let(:provider_username) { user.username }
   let(:provider_user) { OpenStruct.new(login: provider_username) }
@@ -198,7 +198,7 @@ shared_examples 'a GitHub-ish import controller: POST create' do
 
     post :create, format: :json
 
-    expect(response).to have_gitlab_http_status(200)
+    expect(response).to have_gitlab_http_status(:ok)
   end
 
   it 'returns 422 response with the base error when the project could not be imported' do
@@ -212,7 +212,7 @@ shared_examples 'a GitHub-ish import controller: POST create' do
 
     post :create, format: :json
 
-    expect(response).to have_gitlab_http_status(422)
+    expect(response).to have_gitlab_http_status(:unprocessable_entity)
     expect(json_response['errors']).to eq('Name is invalid, Path is old')
   end
 
@@ -484,13 +484,13 @@ shared_examples 'a GitHub-ish import controller: POST create' do
 
         post :create, params: { target_namespace: other_namespace.name }, format: :json
 
-        expect(response).to have_gitlab_http_status(422)
+        expect(response).to have_gitlab_http_status(:unprocessable_entity)
       end
     end
   end
 end
 
-shared_examples 'a GitHub-ish import controller: GET realtime_changes' do
+RSpec.shared_examples 'a GitHub-ish import controller: GET realtime_changes' do
   let(:user) { create(:user) }
 
   before do

spec/support/shared_examples/instance_statistics_controllers_shared_examples.rb → spec/support/shared_examples/controllers/instance_statistics_controllers_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'instance statistics availability' do
+RSpec.shared_examples 'instance statistics availability' do
   let(:user) { create(:user) }
 
   before do

spec/support/shared_examples/controllers/issuable_notes_filter_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'issuable notes filter' do
+RSpec.shared_examples 'issuable notes filter' do
   let(:params) do
     if issuable_parent.is_a?(Project)
       { namespace_id: issuable_parent.namespace, project_id: issuable_parent, id: issuable.iid }

spec/support/shared_examples/issuables_list_metadata_shared_examples.rb → spec/support/shared_examples/controllers/issuables_list_metadata_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'issuables list meta-data' do |issuable_type, action = nil|
+RSpec.shared_examples 'issuables list meta-data' do |issuable_type, action = nil|
   include ProjectForksHelper
 
   def get_action(action, project, extra_params = {})

spec/support/shared_examples/controllers/issuables_requiring_filter_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'issuables requiring filter' do |action|
+RSpec.shared_examples 'issuables requiring filter' do |action|
   it "doesn't load any issuables if no filter is set" do
     expect_any_instance_of(described_class).not_to receive(:issuables_collection)
 

spec/support/shared_examples/milestone_tabs_examples.rb → spec/support/shared_examples/controllers/milestone_tabs_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'milestone tabs' do
+RSpec.shared_examples 'milestone tabs' do
   def go(path, extra_params = {})
     params =
       case milestone

spec/support/shared_examples/controllers/paginated_collection_shared_examples.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
-shared_examples 'paginated collection' do
+RSpec.shared_examples 'paginated collection' do
   let(:collection) { nil }
   let(:last_page) { collection.page.total_pages }
   let(:action) { :index }

spec/support/shared_examples/controllers/repository_lfs_file_load_examples.rb → spec/support/shared_examples/controllers/repository_lfs_file_load_shared_examples.rb

@@ -17,7 +17,7 @@
 # it_behaves_like 'a controller that can serve LFS files', skip_lfs_disabled_tests: true do
 #   ...
 # end
-shared_examples 'a controller that can serve LFS files' do |options = {}|
+RSpec.shared_examples 'a controller that can serve LFS files' do |options = {}|
   let(:lfs_oid) { '91eff75a492a3ed0dfcb544d7f31326bc4014c8551849c192fd1e48d4dd2c897' }
   let(:lfs_size) { '1575078' }
   let!(:lfs_object) { create(:lfs_object, oid: lfs_oid, size: lfs_size) }

spec/support/controllers/sessionless_auth_controller_shared_examples.rb → spec/support/shared_examples/controllers/sessionless_auth_controller_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'authenticates sessionless user' do |path, format, params|
+RSpec.shared_examples 'authenticates sessionless user' do |path, format, params|
   params ||= {}
 
   before do
@@ -20,14 +20,14 @@ shared_examples 'authenticates sessionless user' do |path, format, params|
 
       get path, params: default_params.merge(private_token: personal_access_token.token)
 
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
       expect(controller.current_user).to eq(user)
     end
 
     it 'does not log the user in if page is public', if: params[:public] do
       get path, params: default_params
 
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
       expect(controller.current_user).to be_nil
     end
   end
@@ -48,7 +48,7 @@ shared_examples 'authenticates sessionless user' do |path, format, params|
 
       get path, params: default_params.merge(private_token: personal_access_token.token)
 
-      expect(response).not_to have_gitlab_http_status(200)
+      expect(response).not_to have_gitlab_http_status(:ok)
     end
   end
 
@@ -62,7 +62,7 @@ shared_examples 'authenticates sessionless user' do |path, format, params|
       @request.headers['PRIVATE-TOKEN'] = personal_access_token.token
       get path, params: default_params
 
-      expect(response).to have_gitlab_http_status(200)
+      expect(response).to have_gitlab_http_status(:ok)
     end
   end
 
@@ -75,7 +75,7 @@ shared_examples 'authenticates sessionless user' do |path, format, params|
 
       get path, params: default_params.merge(feed_token: user.feed_token)
 
-      expect(response).to have_gitlab_http_status 200
+      expect(response).to have_gitlab_http_status(:ok)
     end
   end
 

spec/support/shared_examples/controllers/set_sort_order_from_user_preference_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'set sort order from user preference' do
+RSpec.shared_examples 'set sort order from user preference' do
   describe '#set_sort_order_from_user_preference' do
     # There is no sorting_field defined in any CE controllers yet,
     # however any other field present in user_preferences table can be used for testing.

spec/support/shared_examples/controllers/todos_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'todos actions' do
+RSpec.shared_examples 'todos actions' do
   context 'when authorized' do
     before do
       sign_in(user)

spec/support/shared_examples/trackable_shared_examples.rb → spec/support/shared_examples/controllers/trackable_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'a Trackable Controller' do
+RSpec.shared_examples 'a Trackable Controller' do
   describe '#track_event' do
     before do
       sign_in user

spec/support/shared_examples/update_invalid_issuable.rb → spec/support/shared_examples/controllers/update_invalid_issuable_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'update invalid issuable' do |klass|
+RSpec.shared_examples 'update invalid issuable' do |klass|
   let(:params) do
     {
       namespace_id: project.namespace.path,

spec/support/shared_examples/controllers/uploads_actions_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'handle uploads' do
+RSpec.shared_examples 'handle uploads' do
   let(:user)  { create(:user) }
   let(:jpg)   { fixture_file_upload('spec/fixtures/rails_sample.jpg', 'image/jpg') }
   let(:txt)   { fixture_file_upload('spec/fixtures/doc_sample.txt', 'text/plain') }
@@ -287,7 +287,7 @@ shared_examples 'handle uploads' do
   end
 end
 
-shared_examples 'handle uploads authorize' do
+RSpec.shared_examples 'handle uploads authorize' do
   describe "POST #authorize" do
     context 'when a user is not authorized to upload a file' do
       it 'returns 404 status' do

spec/support/shared_examples/controllers/variables_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'GET #show lists all variables' do
+RSpec.shared_examples 'GET #show lists all variables' do
   it 'renders the variables as json' do
     subject
 
@@ -14,7 +14,7 @@ shared_examples 'GET #show lists all variables' do
   end
 end
 
-shared_examples 'PATCH #update updates variables' do
+RSpec.shared_examples 'PATCH #update updates variables' do
   let(:variable_attributes) do
     { id: variable.id,
       key: variable.key,

spec/support/shared_examples/email_shared_examples.rb

-# frozen_string_literal: true
-
-shared_examples_for 'correctly finds the mail key' do
-  specify do
-    expect(Gitlab::Email::Handler).to receive(:for).with(an_instance_of(Mail::Message), 'gitlabhq/gitlabhq+auth_token').and_return(handler)
-
-    receiver.execute
-  end
-end

spec/support/shared_examples/evidence_updated_exposed_fields.rb

-# frozen_string_literal: true
-
-shared_examples 'updated exposed field' do
-  it 'creates another Evidence object' do
-    model.send("#{updated_field}=", updated_value)
-
-    expect(model.evidence_summary_keys).to include(updated_field)
-    expect { model.save! }.to change(Evidence, :count).by(1)
-    expect(updated_json_field).to eq(updated_value)
-  end
-end
-
-shared_examples 'updated non-exposed field' do
-  it 'does not create any Evidence object' do
-    model.send("#{updated_field}=", updated_value)
-
-    expect(model.evidence_summary_keys).not_to include(updated_field)
-    expect { model.save! }.not_to change(Evidence, :count)
-  end
-end
-
-shared_examples 'updated field on non-linked entity' do
-  it 'does not create any Evidence object' do
-    model.send("#{updated_field}=", updated_value)
-
-    expect(model.evidence_summary_keys).to be_empty
-    expect { model.save! }.not_to change(Evidence, :count)
-  end
-end

spec/support/shared_examples/fast_destroy_all.rb

-# frozen_string_literal: true
-
-shared_examples_for 'fast destroyable' do
-  describe 'Forbid #destroy and #destroy_all' do
-    it 'does not delete database rows and associted external data' do
-      expect(external_data_counter).to be > 0
-      expect(subjects.count).to be > 0
-
-      expect { subjects.first.destroy }.to raise_error('`destroy` and `destroy_all` are forbidden. Please use `fast_destroy_all`')
-      expect { subjects.destroy_all }.to raise_error('`destroy` and `destroy_all` are forbidden. Please use `fast_destroy_all`') # rubocop: disable DestroyAll
-
-      expect(subjects.count).to be > 0
-      expect(external_data_counter).to be > 0
-    end
-  end
-
-  describe '.fast_destroy_all' do
-    it 'deletes database rows and associted external data' do
-      expect(external_data_counter).to be > 0
-      expect(subjects.count).to be > 0
-
-      expect { subjects.fast_destroy_all }.not_to raise_error
-
-      expect(subjects.count).to eq(0)
-      expect(external_data_counter).to eq(0)
-    end
-  end
-
-  describe '.use_fast_destroy' do
-    it 'performs cascading delete with fast_destroy_all' do
-      expect(external_data_counter).to be > 0
-      expect(subjects.count).to be > 0
-
-      expect { parent.destroy }.not_to raise_error
-
-      expect(subjects.count).to eq(0)
-      expect(external_data_counter).to eq(0)
-    end
-  end
-end

spec/support/shared_examples/features/archive_download_buttons_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'archive download buttons' do
+RSpec.shared_examples 'archive download buttons' do
   let(:path_to_visit) { project_path(project) }
   let(:ref) { project.default_branch }
 

spec/support/shared_examples/features/comments_on_merge_request_files_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'comment on merge request file' do
+RSpec.shared_examples 'comment on merge request file' do
   it 'adds a comment' do
     click_diff_line(find("[id='#{sample_commit.line_code}']"))
 

spec/support/shared_examples/dirty_submit_form_shared_examples.rb → spec/support/shared_examples/features/dirty_submit_form_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'dirty submit form' do |selector_args|
+RSpec.shared_examples 'dirty submit form' do |selector_args|
   selectors = selector_args.is_a?(Array) ? selector_args : [selector_args]
 
   def expect_disabled_state(form, submit_selector, is_disabled = true)

spec/support/features/discussion_comments_shared_example.rb → spec/support/shared_examples/features/discussion_comments_shared_example.rb

 # frozen_string_literal: true
 
-shared_examples 'thread comments' do |resource_name|
+RSpec.shared_examples 'thread comments' do |resource_name|
   let(:form_selector) { '.js-main-target-form' }
   let(:dropdown_selector) { "#{form_selector} .comment-type-dropdown" }
   let(:toggle_selector) { "#{dropdown_selector} .dropdown-toggle" }

spec/support/shared_examples/features/issuable_sidebar_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'issue sidebar stays collapsed on mobile' do
+RSpec.shared_examples 'issue sidebar stays collapsed on mobile' do
   before do
     resize_screen_xs
   end

spec/support/shared_examples/features/issuables_user_dropdown_behaviors_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'issuable user dropdown behaviors' do
+RSpec.shared_examples 'issuable user dropdown behaviors' do
   include FilteredSearchHelpers
 
   before do

spec/support/shared_examples/features/multiple_assignees_mr_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'multiple assignees merge request' do |action, save_button_title|
+RSpec.shared_examples 'multiple assignees merge request' do |action, save_button_title|
   it "#{action} a MR with multiple assignees", :js do
     find('.js-assignee-search').click
     page.within '.dropdown-menu-user' do

spec/support/shared_examples/features/project_features_apply_to_issuables_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'project features apply to issuables' do |klass|
+RSpec.shared_examples 'project features apply to issuables' do |klass|
   let(:described_class) { klass }
 
   let(:group) { create(:group) }

spec/support/shared_examples/project_list_shared_examples.rb → spec/support/shared_examples/features/project_list_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'shows public projects' do
+RSpec.shared_examples 'shows public projects' do
   it 'shows projects' do
     expect(page).to have_content(public_project.title)
     expect(page).not_to have_content(internal_project.title)
@@ -9,7 +9,7 @@ shared_examples 'shows public projects' do
   end
 end
 
-shared_examples 'shows public and internal projects' do
+RSpec.shared_examples 'shows public and internal projects' do
   it 'shows projects' do
     expect(page).to have_content(public_project.title)
     expect(page).to have_content(internal_project.title)

spec/support/shared_examples/features/protected_branches_access_control_ce.rb → spec/support/shared_examples/features/protected_branches_access_control_ce_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples "protected branches > access control > CE" do
+RSpec.shared_examples "protected branches > access control > CE" do
   ProtectedRefAccess::HUMAN_ACCESS_LEVELS.each do |(access_type_id, access_type_name)|
     it "allows creating protected branches that #{access_type_name} can push to" do
       visit project_protected_branches_path(project)

spec/support/features/reportable_note_shared_examples.rb → spec/support/shared_examples/features/reportable_note_shared_examples.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
-shared_examples 'reportable note' do |type|
+RSpec.shared_examples 'reportable note' do |type|
   include MobileHelpers
   include NotesHelper
 

spec/support/features/resolving_discussions_in_issues_shared_examples.rb → spec/support/shared_examples/features/resolving_discussions_in_issues_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'creating an issue for a thread' do
+RSpec.shared_examples 'creating an issue for a thread' do
   it 'shows an issue with the title filled in' do
     title_field = page.find_field('issue[title]')
 

spec/support/features/rss_shared_examples.rb → spec/support/shared_examples/features/rss_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples "an autodiscoverable RSS feed with current_user's feed token" do
+RSpec.shared_examples "an autodiscoverable RSS feed with current_user's feed token" do
   it "has an RSS autodiscovery link tag with current_user's feed token" do
     expect(page).to have_css("link[type*='atom+xml'][href*='feed_token=#{user.feed_token}']", visible: false)
   end
 end
 
-shared_examples "it has an RSS button with current_user's feed token" do
+RSpec.shared_examples "it has an RSS button with current_user's feed token" do
   it "shows the RSS button with current_user's feed token" do
     expect(page)
       .to have_css("a:has(.fa-rss)[href*='feed_token=#{user.feed_token}']")
@@ -14,13 +14,13 @@ shared_examples "it has an RSS button with current_user's feed token" do
   end
 end
 
-shared_examples "an autodiscoverable RSS feed without a feed token" do
+RSpec.shared_examples "an autodiscoverable RSS feed without a feed token" do
   it "has an RSS autodiscovery link tag without a feed token" do
     expect(page).to have_css("link[type*='atom+xml']:not([href*='feed_token'])", visible: false)
   end
 end
 
-shared_examples "it has an RSS button without a feed token" do
+RSpec.shared_examples "it has an RSS button without a feed token" do
   it "shows the RSS button without a feed token" do
     expect(page)
       .to have_css("a:has(.fa-rss):not([href*='feed_token'])")

spec/support/shared_examples/features/search_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'top right search form' do
+RSpec.shared_examples 'top right search form' do
   it 'does not show top right search form' do
     expect(page).not_to have_selector('.search')
   end

spec/support/shared_examples/showing_user_status_shared_examples.rb → spec/support/shared_examples/features/showing_user_status_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'showing user status' do
+RSpec.shared_examples 'showing user status' do
   let!(:status) { create(:user_status, user: user_with_status, emoji: 'smirk', message: 'Authoring this object') }
 
   it 'shows the status' do

spec/support/features/variable_list_shared_examples.rb → spec/support/shared_examples/features/variable_list_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'variable list' do
+RSpec.shared_examples 'variable list' do
   it 'shows list of variables' do
     page.within('.js-ci-variable-list-section') do
       expect(first('.js-ci-variable-input-key').value).to eq(variable.key)

spec/support/shared_examples/wiki_file_attachments_examples.rb → spec/support/shared_examples/features/wiki_file_attachments_shared_examples.rb

@@ -3,7 +3,7 @@
 # Requires a context containing:
 #   project
 
-shared_examples 'wiki file attachments' do
+RSpec.shared_examples 'wiki file attachments' do
   include DropzoneHelper
 
   context 'uploading attachments', :js do

spec/support/shared_examples/finders/assignees_filter_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'assignee ID filter' do
+RSpec.shared_examples 'assignee ID filter' do
   it 'returns issuables assigned to that user' do
     expect(issuables).to contain_exactly(*expected_issuables)
   end
 end
 
-shared_examples 'assignee NOT ID filter' do
+RSpec.shared_examples 'assignee NOT ID filter' do
   it 'returns issuables not assigned to that user' do
     expect(issuables).to contain_exactly(*expected_issuables)
   end
 end
 
-shared_examples 'assignee username filter' do
+RSpec.shared_examples 'assignee username filter' do
   it 'returns issuables assigned to those users' do
     expect(issuables).to contain_exactly(*expected_issuables)
   end
 end
 
-shared_examples 'assignee NOT username filter' do
+RSpec.shared_examples 'assignee NOT username filter' do
   it 'returns issuables not assigned to those users' do
     expect(issuables).to contain_exactly(*expected_issuables)
   end
 end
 
-shared_examples 'no assignee filter' do
+RSpec.shared_examples 'no assignee filter' do
   let(:params) { { assignee_id: 'None' } }
 
   it 'returns issuables not assigned to any assignee' do
@@ -38,7 +38,7 @@ shared_examples 'no assignee filter' do
   end
 end
 
-shared_examples 'any assignee filter' do
+RSpec.shared_examples 'any assignee filter' do
   context '' do
     let(:params) { { assignee_id: 'Any' } }
 

spec/support/shared_examples/finders/finder_with_external_authorization_enabled.rb → spec/support/shared_examples/finders/finder_with_external_authorization_enabled_shared_examples.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
-shared_examples 'a finder with external authorization service' do
+RSpec.shared_examples 'a finder with external authorization service' do
   include ExternalAuthorizationServiceHelpers
 
   let(:user) { create(:user) }

spec/support/shared_examples/graphql/failure_to_find_anything.rb → spec/support/shared_examples/graphql/failure_to_find_anything_shared_examples.rb

 # frozen_string_literal: true
 
-require 'spec_helper'
-
 # Shared example for legal queries that are expected to return nil.
 # Requires the following let bindings to be defined:
 #  - post_query: action to send the query
 #  - path: array of keys from query root to the result
-shared_examples 'a failure to find anything' do
+RSpec.shared_examples 'a failure to find anything' do
   it 'finds nothing' do
     post_query
 

spec/support/shared_examples/graphql/notes_on_noteables_shared_examples.rb

 # frozen_string_literal: true
-require 'spec_helper'
 
-shared_context 'exposing regular notes on a noteable in GraphQL' do
+RSpec.shared_context 'exposing regular notes on a noteable in GraphQL' do
   include GraphqlHelpers
 
   let(:note) do

spec/support/shared_examples/uses_gitlab_url_blocker_examples.rb → spec/support/shared_examples/initializers/uses_gitlab_url_blocker_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'a request using Gitlab::UrlBlocker' do
+RSpec.shared_examples 'a request using Gitlab::UrlBlocker' do
   # Written to test internal patches against 3rd party libraries
   #
   # Expects the following to be available in the example contexts:

spec/support/shared_examples/legacy_path_redirect_shared_examples.rb

-# frozen_string_literal: true
-
-shared_examples 'redirecting a legacy path' do |source, target|
-  include RSpec::Rails::RequestExampleGroup
-
-  it "redirects #{source} to #{target} when the resource does not exist" do
-    expect(get(source)).to redirect_to(target)
-  end
-
-  it "does not redirect #{source} to #{target} when the resource exists" do
-    resource
-
-    expect(get(source)).not_to redirect_to(target)
-  end
-end
-
-shared_examples 'redirecting a legacy project path' do |source, target|
-  include RSpec::Rails::RequestExampleGroup
-
-  it "redirects #{source} to #{target}" do
-    expect(get(source)).to redirect_to(target)
-  end
-end

spec/support/shared_examples/lib/gitlab/background_migration/backfill_project_repositories_examples.rb → spec/support/shared_examples/lib/gitlab/background_migration/backfill_project_repositories_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'backfill migration for project repositories' do |storage|
+RSpec.shared_examples 'backfill migration for project repositories' do |storage|
   describe '#perform' do
     let(:storage_versions) { storage == :legacy ? [nil, 0] : [1, 2] }
     let(:storage_version) { storage_versions.first }

spec/support/shared_examples/ci_trace_shared_examples.rb → spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples_for 'common trace features' do
+RSpec.shared_examples 'common trace features' do
   describe '#html' do
     before do
       trace.set("12\n34")
@@ -284,7 +284,7 @@ shared_examples_for 'common trace features' do
   end
 end
 
-shared_examples_for 'trace with disabled live trace feature' do
+RSpec.shared_examples 'trace with disabled live trace feature' do
   it_behaves_like 'common trace features'
 
   describe '#read' do
@@ -618,7 +618,7 @@ shared_examples_for 'trace with disabled live trace feature' do
   end
 end
 
-shared_examples_for 'trace with enabled live trace feature' do
+RSpec.shared_examples 'trace with enabled live trace feature' do
   it_behaves_like 'common trace features'
 
   describe '#read' do

spec/support/shared_examples/cycle_analytics_event_shared_examples.rb → spec/support/shared_examples/lib/gitlab/cycle_analytics_event_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples_for 'cycle analytics event' do
+RSpec.shared_examples_for 'cycle analytics event' do
   let(:params) { {} }
   let(:instance) { described_class.new(params) }
 

spec/support/shared_examples/diff_file_collections.rb → spec/support/shared_examples/lib/gitlab/diff_file_collections_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'diff statistics' do |test_include_stats_flag: true|
+RSpec.shared_examples 'diff statistics' do |test_include_stats_flag: true|
   subject { described_class.new(diffable, collection_default_args) }
 
   def stub_stats_find_by_path(path, stats_mock)
@@ -42,7 +42,7 @@ shared_examples 'diff statistics' do |test_include_stats_flag: true|
   end
 end
 
-shared_examples 'unfoldable diff' do
+RSpec.shared_examples 'unfoldable diff' do
   let(:subject) { described_class.new(diffable, diff_options: nil) }
 
   it 'calls Gitlab::Diff::File#unfold_diff_lines with correct position' do
@@ -58,7 +58,7 @@ shared_examples 'unfoldable diff' do
   end
 end
 
-shared_examples 'cacheable diff collection' do
+RSpec.shared_examples 'cacheable diff collection' do
   let(:cache) { instance_double(Gitlab::Diff::HighlightCache) }
 
   before do

spec/support/shared_examples/file_finder.rb → spec/support/shared_examples/lib/gitlab/file_finder_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'file finder' do
+RSpec.shared_examples 'file finder' do
   let(:query) { 'files' }
   let(:search_results) { subject.find(query) }
 

spec/support/shared_examples/helm_generated_script.rb → spec/support/shared_examples/lib/gitlab/helm_generated_script_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'helm commands' do
+RSpec.shared_examples 'helm commands' do
   describe '#generate_script' do
     let(:helm_setup) do
       <<~EOS

spec/support/shared_examples/lib/gitlab/import_export/import_failure_service_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'log import failure' do |importable_column|
+RSpec.shared_examples 'log import failure' do |importable_column|
   it 'tracks error' do
     extra = {
               relation_key: relation_key,

spec/support/shared_examples/ldap_shared_examples.rb → spec/support/shared_examples/lib/gitlab/ldap_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples_for 'normalizes a DN' do
+RSpec.shared_examples 'normalizes a DN' do
   using RSpec::Parameterized::TableSyntax
 
   where(:test_description, :given, :expected) do
@@ -40,7 +40,7 @@ shared_examples_for 'normalizes a DN' do
   end
 end
 
-shared_examples_for 'normalizes a DN attribute value' do
+RSpec.shared_examples 'normalizes a DN attribute value' do
   using RSpec::Parameterized::TableSyntax
 
   where(:test_description, :given, :expected) do

spec/support/shared_examples/malicious_regexp_shared_examples.rb → spec/support/shared_examples/lib/gitlab/malicious_regexp_shared_examples.rb

@@ -2,7 +2,7 @@
 
 require 'timeout'
 
-shared_examples 'malicious regexp' do
+RSpec.shared_examples 'malicious regexp' do
   let(:malicious_text) { 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa!' }
   let(:malicious_regexp_re2) { '(?i)^(([a-z])+.)+[A-Z]([a-z])+$' }
   let(:malicious_regexp_ruby) { '/^(([a-z])+.)+[A-Z]([a-z])+$/i' }

spec/support/shared_examples/migration_helpers_examples.rb → spec/support/shared_examples/lib/gitlab/migration_helpers_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'skips validation' do |validation_option|
+RSpec.shared_examples 'skips validation' do |validation_option|
   it 'skips validation' do
     expect(model).not_to receive(:disable_statement_timeout)
     expect(model).to receive(:execute).with(/ADD CONSTRAINT/)
@@ -10,7 +10,7 @@ shared_examples 'skips validation' do |validation_option|
   end
 end
 
-shared_examples 'performs validation' do |validation_option|
+RSpec.shared_examples 'performs validation' do |validation_option|
   it 'performs validation' do
     expect(model).to receive(:disable_statement_timeout).and_call_original
     expect(model).to receive(:execute).with(/statement_timeout/)

spec/support/shared_examples/position_formatters.rb → spec/support/shared_examples/lib/gitlab/position_formatters_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples_for "position formatter" do
+RSpec.shared_examples "position formatter" do
   let(:formatter) { described_class.new(attrs) }
 
   describe '#key' do

spec/support/shared_examples/repo_type_shared_examples.rb → spec/support/shared_examples/lib/gitlab/repo_type_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'a repo type' do
+RSpec.shared_examples 'a repo type' do
   describe "#identifier_for_repositorable" do
     subject { described_class.identifier_for_repositorable(project) }
 

spec/support/shared_examples/unique_ip_check_shared_examples.rb → spec/support/shared_examples/lib/gitlab/unique_ip_check_shared_examples.rb

 # frozen_string_literal: true
 
-shared_context 'unique ips sign in limit' do
-  include StubENV
-  let(:request_context) { Gitlab::RequestContext.instance }
-
-  before do
-    Gitlab::Redis::Cache.with(&:flushall)
-    Gitlab::Redis::Queues.with(&:flushall)
-    Gitlab::Redis::SharedState.with(&:flushall)
-  end
-
-  before do
-    stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
-
-    Gitlab::CurrentSettings.update!(
-      unique_ips_limit_enabled: true,
-      unique_ips_limit_time_window: 10000
-    )
-
-    # Make sure we're working with the same reqeust context everywhere
-    allow(Gitlab::RequestContext).to receive(:instance).and_return(request_context)
-  end
-
-  def change_ip(ip)
-    allow(request_context).to receive(:client_ip).and_return(ip)
-  end
-
-  def request_from_ip(ip)
-    change_ip(ip)
-    request
-    response
-  end
-
-  def operation_from_ip(ip)
-    change_ip(ip)
-    operation
-  end
-end
-
-shared_examples 'user login operation with unique ip limit' do
+RSpec.shared_examples 'user login operation with unique ip limit' do
   include_context 'unique ips sign in limit' do
     before do
       Gitlab::CurrentSettings.update!(unique_ips_limit_per_user: 1)
@@ -56,7 +18,7 @@ shared_examples 'user login operation with unique ip limit' do
   end
 end
 
-shared_examples 'user login request with unique ip limit' do |success_status = 200|
+RSpec.shared_examples 'user login request with unique ip limit' do |success_status = 200|
   include_context 'unique ips sign in limit' do
     before do
       Gitlab::CurrentSettings.update!(unique_ips_limit_per_user: 1)

spec/support/shared_examples/lib/gitlab/usage_data_counters/a_redis_counter.rb → spec/support/shared_examples/lib/gitlab/usage_data_counters/a_redis_counter_shared_examples.rb

 # frozen_string_literal: true
 
-shared_examples 'a redis usage counter' do |thing, event|
+RSpec.shared_examples 'a redis usage counter' do |thing, event|
   describe ".count(#{event})", :clean_gitlab_redis_shared_state do
     it "increments the #{thing} #{event} counter by 1" do
       expect do
@@ -22,7 +22,7 @@ shared_examples 'a redis usage counter' do |thing, event|
   end
 end
 
-shared_examples 'a redis usage counter with totals' do |prefix, events|
+RSpec.shared_examples 'a redis usage counter with totals' do |prefix, events|
   describe 'totals', :clean_gitlab_redis_shared_state do
     before do
       events.each do |k, n|