Commit d044b519 authored by Alex Kalderimis's avatar Alex Kalderimis

Rename GitLab slack application Integration

Renames project association for GitLab slack application from
gitlab_slack_application_service to
gitlab_slack_application_integration.
parent b25c85a1
......@@ -47,7 +47,7 @@ module Projects
def redirect_to_service_page
redirect_to edit_project_service_path(
project,
project.gitlab_slack_application_service || project.build_gitlab_slack_application_service
project.gitlab_slack_application_integration || project.build_gitlab_slack_application_integration
)
end
......@@ -65,11 +65,11 @@ module Projects
end
def slack_integration
@slack_integration ||= project.gitlab_slack_application_service.slack_integration
@slack_integration ||= project.gitlab_slack_application_integration.slack_integration
end
def service
@service = project.gitlab_slack_application_service
@service = project.gitlab_slack_application_integration
end
def slack_integration_params
......
......@@ -42,7 +42,7 @@ module EE
has_one :index_status
has_one :github_integration, class_name: 'Integrations::Github'
has_one :gitlab_slack_application_service, class_name: 'Integrations::GitlabSlackApplication'
has_one :gitlab_slack_application_integration, class_name: 'Integrations::GitlabSlackApplication'
has_one :status_page_setting, inverse_of: :project, class_name: 'StatusPage::ProjectSetting'
has_one :compliance_framework_setting, class_name: 'ComplianceManagement::ComplianceFramework::ProjectSettings', inverse_of: :project
......
......@@ -11,11 +11,11 @@ module Projects
return error("Slack: #{slack_data['error']}") unless slack_data['ok']
unless project.gitlab_slack_application_service
project.create_gitlab_slack_application_service
unless project.gitlab_slack_application_integration
project.create_gitlab_slack_application_integration
end
service = project.gitlab_slack_application_service
service = project.gitlab_slack_application_integration
SlackIntegration.create!(
service_id: service.id,
......@@ -34,17 +34,17 @@ module Projects
# rubocop: disable CodeReuse/ActiveRecord
def make_sure_chat_name_created(slack_data)
service = project.gitlab_slack_application_service
integration = project.gitlab_slack_application_integration
chat_name = ChatName.find_by(
service_id: service.id,
service_id: integration.id,
team_id: slack_data['team_id'],
chat_id: slack_data['user_id']
)
unless chat_name
ChatName.find_or_create_by!(
service_id: service.id,
service_id: integration.id,
team_id: slack_data['team_id'],
team_domain: slack_data['team_name'],
chat_id: slack_data['user_id'],
......
......@@ -15,7 +15,7 @@ RSpec.describe Projects::Settings::SlacksController do
def redirect_url(project)
edit_project_service_path(
project,
project.build_gitlab_slack_application_service
project.build_gitlab_slack_application_integration
)
end
......
# frozen_string_literal: true
FactoryBot.define do
factory :gitlab_slack_application_service, class: 'Integrations::GitlabSlackApplication' do
factory :gitlab_slack_application_integration, class: 'Integrations::GitlabSlackApplication' do
project
active { true }
type { 'GitlabSlackApplicationService' }
......
......@@ -7,6 +7,6 @@ FactoryBot.define do
sequence(:team_name) { |n| "team#{n}" }
sequence(:alias) { |n| "namespace#{n}/project_name#{n}" }
integration factory: :gitlab_slack_application_service
integration factory: :gitlab_slack_application_integration
end
end
......@@ -6,14 +6,14 @@ RSpec.describe 'Slack application' do
let(:project) { create(:project) }
let(:user) { create(:user) }
let(:role) { :developer }
let(:service) { create(:gitlab_slack_application_service, project: project) }
let(:slack_application_form_path) { edit_project_service_path(project, service) }
let(:integration) { create(:gitlab_slack_application_integration, project: project) }
let(:slack_application_form_path) { edit_project_service_path(project, integration) }
before do
gitlab_sign_in(user)
project.add_maintainer(user)
create(:slack_integration, integration: service)
create(:slack_integration, integration: integration)
allow(Gitlab).to receive(:com?).and_return(true)
allow(Gitlab::CurrentSettings).to receive(:slack_app_enabled).and_return(true)
......
......@@ -1571,7 +1571,7 @@ RSpec.describe Project do
it 'returns projects where Slack application is disabled' do
project1 = create(:project)
project2 = create(:project)
create(:gitlab_slack_application_service, project: project2)
create(:gitlab_slack_application_integration, project: project2)
projects = described_class.with_slack_application_disabled
......
......@@ -11,7 +11,7 @@ RSpec.describe API::Services do
describe 'Slack application Service' do
before do
project.create_gitlab_slack_application_service
project.create_gitlab_slack_application_integration
stub_application_setting(
slack_app_verification_token: 'token'
......
......@@ -17,12 +17,12 @@ RSpec.describe Projects::SlackApplicationInstallService do
end
def expect_slack_integration_is_created(project)
integration = SlackIntegration.find_by(service_id: project.gitlab_slack_application_service.id)
integration = SlackIntegration.find_by(service_id: project.gitlab_slack_application_integration.id)
expect(integration).to be_present
end
def expect_chat_name_is_created(project)
chat_name = ChatName.find_by(service_id: project.gitlab_slack_application_service.id)
chat_name = ChatName.find_by(service_id: project.gitlab_slack_application_integration.id)
expect(chat_name).to be_present
end
......
......@@ -15,7 +15,7 @@ RSpec.describe SlashCommands::GlobalSlackHandler do
end
def enable_slack_application(project)
create(:gitlab_slack_application_service, project: project)
create(:gitlab_slack_application_integration, project: project)
end
def handler(params)
......@@ -39,7 +39,7 @@ RSpec.describe SlashCommands::GlobalSlackHandler do
enable_slack_application(project)
slack_integration = create(:slack_integration, integration: project.gitlab_slack_application_service)
slack_integration = create(:slack_integration, integration: project.gitlab_slack_application_integration)
slack_integration.update(alias: project.full_path)
handler_with_valid_token(
......@@ -54,7 +54,7 @@ RSpec.describe SlashCommands::GlobalSlackHandler do
enable_slack_application(project)
slack_integration = create(:slack_integration, integration: project.gitlab_slack_application_service)
slack_integration = create(:slack_integration, integration: project.gitlab_slack_application_integration)
handler_with_valid_token(
text: "fake/fake issue new title",
......@@ -68,7 +68,7 @@ RSpec.describe SlashCommands::GlobalSlackHandler do
enable_slack_application(project)
slack_integration = create(:slack_integration, integration: project.gitlab_slack_application_service)
slack_integration = create(:slack_integration, integration: project.gitlab_slack_application_integration)
slack_integration.update(alias: project.full_path)
handler_with_valid_token(
......
......@@ -480,7 +480,7 @@ project:
- kubernetes_namespaces
- error_tracking_setting
- metrics_setting
- gitlab_slack_application_service
- gitlab_slack_application_integration
- github_integration
- protected_environments
- mirror_user
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment