Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d2070e2e
Commit
d2070e2e
authored
Feb 02, 2021
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed resolvable discussions bugs
parent
101a7f37
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
6 deletions
+5
-6
app/assets/javascripts/notes/stores/mutations.js
app/assets/javascripts/notes/stores/mutations.js
+3
-6
spec/frontend/notes/stores/actions_spec.js
spec/frontend/notes/stores/actions_spec.js
+2
-0
No files found.
app/assets/javascripts/notes/stores/mutations.js
View file @
d2070e2e
...
...
@@ -32,11 +32,7 @@ export default {
}
}
if
(
window
.
gon
?.
features
?.
paginatedNotes
&&
note
.
base_discussion
&&
type
===
constants
.
DIFF_NOTE
)
{
if
(
window
.
gon
?.
features
?.
paginatedNotes
&&
note
.
base_discussion
)
{
if
(
discussion
.
diff_file
)
{
discussion
.
file_hash
=
discussion
.
diff_file
.
file_hash
;
...
...
@@ -45,7 +41,8 @@ export default {
);
}
discussion
.
expanded
=
note
.
expanded
;
discussion
.
resolvable
=
note
.
resolvable
;
discussion
.
expanded
=
note
.
base_discussion
.
expanded
;
discussion
.
resolved
=
note
.
resolved
;
}
...
...
spec/frontend/notes/stores/actions_spec.js
View file @
d2070e2e
...
...
@@ -291,6 +291,7 @@ describe('Actions Notes Store', () => {
[
{
type
:
'
updateOrCreateNotes
'
,
payload
:
discussionMock
.
notes
},
{
type
:
'
startTaskList
'
},
{
type
:
'
updateResolvableDiscussionsCounts
'
},
],
));
});
...
...
@@ -324,6 +325,7 @@ describe('Actions Notes Store', () => {
{
type
:
'
setLoadingState
'
,
payload
:
false
},
{
type
:
'
updateOrCreateNotes
'
,
payload
:
discussionMock
.
notes
},
{
type
:
'
startTaskList
'
},
{
type
:
'
updateResolvableDiscussionsCounts
'
},
],
);
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment