Merge branch 'fix-specs-to-support-parent-strategy-in-factories-2' into 'master'

Refactor tests to support Parent Strategy in factories

See merge request gitlab-org/gitlab!41754

ee/spec/models/ci/subscriptions/project_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 
 RSpec.describe Ci::Subscriptions::Project do
-  let(:upstream_project) { create(:project, :public) }
+  let_it_be(:upstream_project) { create(:project, :public) }
+  let_it_be(:downstream_project) { create(:project) }
 
   describe 'Relations' do
     it { is_expected.to belong_to(:downstream_project).required }
@@ -11,7 +12,7 @@ RSpec.describe Ci::Subscriptions::Project do
   end
 
   it_behaves_like 'includes Limitable concern' do
-    subject { build(:ci_subscriptions_project, upstream_project: upstream_project) }
+    subject { build(:ci_subscriptions_project, upstream_project: upstream_project, downstream_project: downstream_project) }
   end
 
   describe 'Validations' do

ee/spec/models/concerns/geo/eventable_spec.rb

@@ -23,7 +23,7 @@ RSpec.describe Geo::Eventable do
 
   describe '#consumer_klass_name' do
     it 'returns the even class name without the module part' do
-      event = build(:geo_repository_created_event)
+      event = build_stubbed(:geo_repository_created_event)
 
       expect(event.consumer_klass_name).to eq 'RepositoryCreatedEvent'
     end

ee/spec/models/ee/protected_ref_access_spec.rb

@@ -104,6 +104,7 @@ RSpec.describe EE::ProtectedRefAccess do
 
       it "doesn't require access_level if group specified" do
         subject = build(factory_name, access_level: nil, group: create(:group))
+        subject.project.save
         subject.project.project_group_links.create(group: subject.group)
 
         expect(subject).to be_valid

ee/spec/models/geo/event_log_spec.rb

@@ -53,7 +53,7 @@ RSpec.describe Geo::EventLog, type: :model do
     end
 
     it 'returns repository_created_event when set' do
-      repository_created_event = build(:geo_repository_created_event)
+      repository_created_event = build_stubbed(:geo_repository_created_event)
       subject.repository_created_event = repository_created_event
 
       expect(subject.event).to eq repository_created_event