Commit d29a3e9d authored by Bob Van Landuyt's avatar Bob Van Landuyt

Fix static analysis offences

parent 042afb73
...@@ -11,7 +11,7 @@ module EE ...@@ -11,7 +11,7 @@ module EE
# If we don't `protected_branch` or `protected_tag` would be empty and # If we don't `protected_branch` or `protected_tag` would be empty and
# `project` cannot be delegated to it, which in turn would cause validations # `project` cannot be delegated to it, which in turn would cause validations
# to fail. # to fail.
has_many :"#{type}_access_levels", dependent: :destroy, inverse_of: self.model_name.singular has_many :"#{type}_access_levels", inverse_of: self.model_name.singular # rubocop:disable Cop/ActiveRecordDependent
accepts_nested_attributes_for :"#{type}_access_levels", allow_destroy: true accepts_nested_attributes_for :"#{type}_access_levels", allow_destroy: true
......
...@@ -128,7 +128,7 @@ feature 'Projected Tags', feature: true, js: true do ...@@ -128,7 +128,7 @@ feature 'Projected Tags', feature: true, js: true do
protected_tag.create_access_levels.new(user: create(:user, name: 'Jane')) protected_tag.create_access_levels.new(user: create(:user, name: 'Jane'))
.save!(validate: false) .save!(validate: false)
visit namespace_project_settings_repository_path(project.namespace, project) visit project_settings_repository_path(project)
expect(page).to have_content("The following user can also create tags: "\ expect(page).to have_content("The following user can also create tags: "\
"Jane") "Jane")
...@@ -138,7 +138,7 @@ feature 'Projected Tags', feature: true, js: true do ...@@ -138,7 +138,7 @@ feature 'Projected Tags', feature: true, js: true do
protected_tag.create_access_levels.new(group: create(:group, name: 'Team Awesome')) protected_tag.create_access_levels.new(group: create(:group, name: 'Team Awesome'))
.save!(validate: false) .save!(validate: false)
visit namespace_project_settings_repository_path(project.namespace, project) visit project_settings_repository_path(project)
expect(page).to have_content("Members of this group can also create tags: "\ expect(page).to have_content("Members of this group can also create tags: "\
"Team Awesome") "Team Awesome")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment