Update convertScannersToTitleCase util method

- add default input
- remove unnecessary check for array
- update tests

ee/app/assets/javascripts/threat_monitoring/components/policy_editor/utils.js

@@ -130,8 +130,5 @@ export const assignSecurityPolicyProject = async (projectPath) => {
  * @param {Array} scanners (e.g. 'container_scanning', `dast`, etcetera)
  * @returns {Array} (e.g. 'Container Scanning', `Dast`, etcetera)
  */
-export const convertScannersToTitleCase = (scanners) => {
-  if (!Array.isArray(scanners)) return [];
-
-  return scanners.map((scanner) => convertToTitleCase(humanize(scanner)));
-};
+export const convertScannersToTitleCase = (scanners = []) =>
+  scanners.map((scanner) => convertToTitleCase(humanize(scanner)));

ee/spec/frontend/threat_monitoring/components/policy_editor/utils_spec.js

@@ -106,10 +106,10 @@ describe('modifyPolicy', () => {
 
 describe('convertScannersToTitleCase', () => {
   it.each`
-    title                                       | input                                                 | output
-    ${'returns empty array for a non-array'}    | ${{}}                                                 | ${[]}
-    ${'returns empty array for an empty array'} | ${[]}                                                 | ${[]}
-    ${'returns converted array'}                | ${['dast', 'container_scanning', 'secret_detection']} | ${['Dast', 'Container Scanning', 'Secret Detection']}
+    title                                            | input                                                 | output
+    ${'returns empty array if no imput is provided'} | ${undefined}                                          | ${[]}
+    ${'returns empty array for an empty array'}      | ${[]}                                                 | ${[]}
+    ${'returns converted array'}                     | ${['dast', 'container_scanning', 'secret_detection']} | ${['Dast', 'Container Scanning', 'Secret Detection']}
   `('$title', ({ input, output }) => {
     expect(convertScannersToTitleCase(input)).toStrictEqual(output);
   });